Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 8068020: Converts usage of GetBrowserViewForNativeWindow to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporate review feedback, and make ShowPageInfo platform specific Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 28ceec6ac97cdd4b214a9f5903ce98ef6bc24f91..123345ace74065780509a67643715113d8ce34de 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "content/browser/renderer_host/render_view_host.h"
@@ -39,14 +38,14 @@ const int ExtensionPopup::kMaxWidth = 800;
const int ExtensionPopup::kMaxHeight = 600;
ExtensionPopup::ExtensionPopup(
+ Browser* browser,
ExtensionHost* host,
- views::Widget* frame,
const gfx::Rect& relative_to,
views::BubbleBorder::ArrowLocation arrow_location,
bool inspect_with_devtools,
Observer* observer)
- : BrowserBubble(host->view(),
- frame,
+ : BrowserBubble(browser,
+ host->view(),
relative_to,
arrow_location),
relative_to_(relative_to),
@@ -187,9 +186,7 @@ ExtensionPopup* ExtensionPopup::Show(
return NULL;
ExtensionHost* host = manager->CreatePopupHost(url, browser);
- views::Widget* frame = BrowserView::GetBrowserViewForNativeWindow(
- browser->window()->GetNativeHandle())->GetWidget();
- ExtensionPopup* popup = new ExtensionPopup(host, frame, relative_to,
+ ExtensionPopup* popup = new ExtensionPopup(browser, host, relative_to,
arrow_location,
inspect_with_devtools, observer);

Powered by Google App Engine
This is Rietveld 408576698