Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3169)

Unified Diff: chrome/browser/ui/views/browser_bubble.cc

Issue 8068020: Converts usage of GetBrowserViewForNativeWindow to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweaks Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_bubble.cc
diff --git a/chrome/browser/ui/views/browser_bubble.cc b/chrome/browser/ui/views/browser_bubble.cc
index 95075a09c0373072e3a9bd184d5c829752a93bc7..5cafa9a74399ac37506490ce145647a67d0a67d6 100644
--- a/chrome/browser/ui/views/browser_bubble.cc
+++ b/chrome/browser/ui/views/browser_bubble.cc
@@ -4,39 +4,24 @@
#include "chrome/browser/ui/views/browser_bubble.h"
+#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "views/widget/widget.h"
-namespace {
-
-BrowserBubbleHost* GetBubbleHostFromFrame(views::Widget* frame) {
- if (!frame)
- return NULL;
-
- BrowserBubbleHost* bubble_host = NULL;
- views::Widget* window = frame->GetTopLevelWidget();
- if (window) {
- bubble_host = BrowserView::GetBrowserViewForNativeWindow(
- window->GetNativeWindow());
- DCHECK(bubble_host);
- }
-
- return bubble_host;
-}
-
-} // namespace
-
-BrowserBubble::BrowserBubble(views::View* view,
- views::Widget* frame,
+BrowserBubble::BrowserBubble(Browser* browser,
+ views::View* view,
const gfx::Rect& relative_to,
views::BubbleBorder::ArrowLocation arrow_location)
- : frame_(frame),
+ : frame_(NULL),
view_(view),
relative_to_(relative_to),
arrow_location_(arrow_location),
delegate_(NULL),
attached_(false),
- bubble_host_(GetBubbleHostFromFrame(frame)) {
+ bubble_host_(NULL) {
+ BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
+ frame_ = browser_view->GetWidget();
+ bubble_host_ = browser_view;
// Keep relative_to_ in frame-relative coordinates to aid in drag
// positioning.
gfx::Point origin = relative_to_.origin();

Powered by Google App Engine
This is Rietveld 408576698