Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: tests/standalone/io/http_proxy_configuration_test.dart

Issue 80673002: Better handling of IPv6 with HTTP proxy (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_proxy_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_proxy_configuration_test.dart
diff --git a/tests/standalone/io/http_proxy_configuration_test.dart b/tests/standalone/io/http_proxy_configuration_test.dart
index 4bff020028faa507bcabd6ce3afecd989187c452..64aa3b0254e7b5e2eaf9826ce7e8fafb9d3d2f0b 100644
--- a/tests/standalone/io/http_proxy_configuration_test.dart
+++ b/tests/standalone/io/http_proxy_configuration_test.dart
@@ -19,6 +19,8 @@ expectDirect(String uri, environment) {
main() {
expectDirect("http://www.google.com", {});
+ expectDirect("http://www.google.com", {"http_proxy": ""});
+ expectDirect("http://www.google.com", {"http_proxy": " "});
expect("PROXY www.proxy.com:1080",
"http://www.google.com",
@@ -35,12 +37,33 @@ main() {
expect("PROXY www.proxy.com:8080",
"http://www.google.com",
{"http_proxy": "www.proxy.com:8080",
- "https_proxy": "www.proxy.com:8080"});
+ "https_proxy": "www.proxys.com:8080"});
expect("PROXY www.proxys.com:8080",
"https://www.google.com",
{"http_proxy": "www.proxy.com:8080",
"https_proxy": "www.proxys.com:8080"});
+ expect("PROXY [::FFFF:1]:1080",
+ "http://www.google.com",
+ {"http_proxy": "[::FFFF:1]"});
+ expect("PROXY [::FFFF:2]:1080",
+ "https://www.google.com",
+ {"https_proxy": "[::FFFF:2]"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "[::FFFF:1]:8080"});
+ expect("PROXY [::FFFF:2]:8080",
+ "https://www.google.com",
+ {"https_proxy": "[::FFFF:2]:8080"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "[::FFFF:1]:8080",
+ "https_proxy": "[::FFFF:2]:8080"});
+ expect("PROXY [::FFFF:2]:8080",
+ "https://www.google.com",
+ {"http_proxy": "[::FFFF:1]:8080",
+ "https_proxy": "[::FFFF:2]:8080"});
+
expect("PROXY www.proxy.com:1080",
"http://www.google.com",
{"http_proxy": "http://www.proxy.com"});
@@ -56,7 +79,7 @@ main() {
expect("PROXY www.proxy.com:8080",
"http://www.google.com",
{"http_proxy": "http://www.proxy.com:8080/",
- "https_proxy": "http://www.proxy.com:8080/"});
+ "https_proxy": "http://www.proxys.com:8080/"});
expect("PROXY www.proxys.com:8080",
"https://www.google.com",
{"http_proxy": "http://www.proxy.com:8080/",
@@ -64,12 +87,41 @@ main() {
expect("PROXY www.proxy.com:8080",
"http://www.google.com",
{"http_proxy": "http://www.proxy.com:8080/",
- "https_proxy": "http://www.proxy.com:8080/index.html"});
+ "https_proxy": "http://www.proxys.com:8080/index.html"});
expect("PROXY www.proxys.com:8080",
"https://www.google.com",
{"http_proxy": "http://www.proxy.com:8080/",
"https_proxy": "http://www.proxys.com:8080/index.html"});
+ expect("PROXY [::FFFF:1]:1080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]"});
+ expect("PROXY [::FFFF:1]:1080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]/"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/index.html"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/",
+ "https_proxy": "http://[::FFFF:1]:8080/"});
+ expect("PROXY [::FFFF:2]:8080",
+ "https://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/",
+ "https_proxy": "http://[::FFFF:2]:8080/"});
+ expect("PROXY [::FFFF:1]:8080",
+ "http://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/",
+ "https_proxy": "http://[::FFFF:1]:8080/index.html"});
+ expect("PROXY [::FFFF:2]:8080",
+ "https://www.google.com",
+ {"http_proxy": "http://[::FFFF:1]:8080/",
+ "https_proxy": "http://[::FFFF:2]:8080/index.html"});
+
expectDirect("http://www.google.com",
{"http_proxy": "www.proxy.com:8080",
"no_proxy": "www.google.com"});
@@ -87,4 +139,20 @@ main() {
"no_proxy": ",, , www.google.edu,,.com "});
expectDirect("http://www.google.com",
{"https_proxy": "www.proxy.com:8080"});
+
+ expect("PROXY www.proxy.com:8080",
+ "http://[::FFFF:1]",
+ {"http_proxy": "www.proxy.com:8080",
+ "no_proxy": "["});
+ expect("PROXY www.proxy.com:8080",
+ "http://[::FFFF:1]",
+ {"http_proxy": "www.proxy.com:8080",
+ "no_proxy": "[]"});
+
+ expectDirect("http://[::FFFF:1]",
+ {"http_proxy": "www.proxy.com:8080",
+ "no_proxy": "[::FFFF:1]"});
+ expectDirect("http://[::FFFF:1]",
+ {"http_proxy": "www.proxy.com:8080",
+ "no_proxy": ",, , www.google.edu,,[::FFFF:1] "});
}
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_proxy_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698