Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 806713002: Remove const from createPopupMenu (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 void ChromeClientImpl::updateCompositedSelectionBounds(const CompositedSelection Bound& anchor, const CompositedSelectionBound& focus) 717 void ChromeClientImpl::updateCompositedSelectionBounds(const CompositedSelection Bound& anchor, const CompositedSelectionBound& focus)
718 { 718 {
719 m_webView->updateCompositedSelectionBounds(toWebSelectionBound(anchor), toWe bSelectionBound(focus)); 719 m_webView->updateCompositedSelectionBounds(toWebSelectionBound(anchor), toWe bSelectionBound(focus));
720 } 720 }
721 721
722 bool ChromeClientImpl::hasOpenedPopup() const 722 bool ChromeClientImpl::hasOpenedPopup() const
723 { 723 {
724 return m_webView->hasOpenedPopup(); 724 return m_webView->hasOpenedPopup();
725 } 725 }
726 726
727 PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client) const 727 PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client)
728 { 728 {
729 if (WebViewImpl::useExternalPopupMenus()) 729 if (WebViewImpl::useExternalPopupMenus())
730 return adoptRefWillBeNoop(new ExternalPopupMenu(frame, client, *m_webVie w)); 730 return adoptRefWillBeNoop(new ExternalPopupMenu(frame, client, *m_webVie w));
731 731
732 return adoptRefWillBeNoop(new PopupMenuChromium(frame, client)); 732 return adoptRefWillBeNoop(new PopupMenuChromium(frame, client));
733 } 733 }
734 734
735 PagePopup* ChromeClientImpl::openPagePopup(PagePopupClient* client, const IntRec t& originBoundsInRootView) 735 PagePopup* ChromeClientImpl::openPagePopup(PagePopupClient* client, const IntRec t& originBoundsInRootView)
736 { 736 {
737 return m_webView->openPagePopup(client, originBoundsInRootView); 737 return m_webView->openPagePopup(client, originBoundsInRootView);
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
863 { 863 {
864 // FIXME: remove. See http://crbug.com/425756 864 // FIXME: remove. See http://crbug.com/425756
865 if (m_webView->autofillClient()) 865 if (m_webView->autofillClient())
866 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put)); 866 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put));
867 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(input.document(). frame()); 867 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(input.document(). frame());
868 if (webframe->autofillClient()) 868 if (webframe->autofillClient())
869 webframe->autofillClient()->openTextDataListChooser(WebInputElement(&inp ut)); 869 webframe->autofillClient()->openTextDataListChooser(WebInputElement(&inp ut));
870 } 870 }
871 871
872 } // namespace blink 872 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698