Issue 806693011: Keep AllocationSpace and ObjectSpace enums in sync.

Issue 806693011: Keep AllocationSpace and ObjectSpace enums in sync. (Closed)

Created:
6 years ago by Hannes Payer (out of office)

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Keep AllocationSpace and ObjectSpace enums in sync. BUG= Committed: https://crrev.com/c37e09d7ea1880ec128528085cf9008442041deb Cr-Commit-Position: refs/heads/master@{#25917}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
M	include/v8.h	View		1 chunk	+13 lines, -12 lines	0 comments	Download
M	src/globals.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/spaces.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 9 (2 generated)

Benedikt Meurer

Can we somehow assert that this is correct? I.e. add some COMPILE_ASSERTs/STATIC_ASSERTs?

6 years ago (2014-12-22 07:57:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806693011/20001

6 years ago (2014-12-22 08:25:32 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-22 08:52:36 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c37e09d7ea1880ec128528085cf9008442041deb
Cr-Commit-Position: refs/heads/master@{#25917}