Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: tools/PictureResultsWriter.h

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/PictureRenderer.cpp ('k') | tools/iOSShell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/PictureResultsWriter.h
diff --git a/tools/PictureResultsWriter.h b/tools/PictureResultsWriter.h
index da005ad257a68721022c701a392c578b9bba34fa..d3d346fd1cd37e6efde648c46d44d3ef9767f4aa 100644
--- a/tools/PictureResultsWriter.h
+++ b/tools/PictureResultsWriter.h
@@ -56,22 +56,22 @@ public:
fWriters.push_back(newWriter);
}
virtual ~PictureResultsMultiWriter() {}
- virtual void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->bench(name, x, y);
}
}
- virtual void logRenderer(sk_tools::PictureRenderer *pr) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer *pr) SK_OVERRIDE {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->logRenderer(pr);
}
}
- virtual void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
+ void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->tileMeta(x, y, tx, ty);
}
}
- virtual void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
+ void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->addTileFlag(flag);
}
@@ -87,7 +87,7 @@ public:
numInnerLoops);
}
}
- virtual void end() SK_OVERRIDE {
+ void end() SK_OVERRIDE {
for(int i=0; i<fWriters.count(); ++i) {
fWriters[i]->end();
}
@@ -109,18 +109,18 @@ private:
public:
PictureResultsLoggerWriter(BenchLogger* log)
: fLogger(log), fCurrentLine() {}
- virtual void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
SkString result;
result.printf("running bench [%i %i] %s ", x, y, name);
this->logProgress(result.c_str());
}
- virtual void logRenderer(sk_tools::PictureRenderer* renderer) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer* renderer) SK_OVERRIDE {
fCurrentLine = renderer->getConfigName();
}
- virtual void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
+ void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {
fCurrentLine.appendf(": tile [%i,%i] out of [%i,%i]", x, y, tx, ty);
}
- virtual void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
+ void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {
if(flag == PictureResultsWriter::kPurging) {
fCurrentLine.append(" <withPurging>");
} else if(flag == PictureResultsWriter::kAvg) {
@@ -138,7 +138,7 @@ public:
results.append("\n");
this->logProgress(results.c_str());
}
- virtual void end() SK_OVERRIDE {}
+ void end() SK_OVERRIDE {}
private:
BenchLogger* fLogger;
SkString fCurrentLine;
@@ -189,17 +189,17 @@ public:
fBuilderData = this->makeBuilderJson();
}
- virtual void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
+ void bench(const char name[], int32_t x, int32_t y) SK_OVERRIDE {
fBenchName = SkString(name);
}
- virtual void logRenderer(sk_tools::PictureRenderer* pr) SK_OVERRIDE {
+ void logRenderer(sk_tools::PictureRenderer* pr) SK_OVERRIDE {
fParams = pr->getJSONConfig();
fConfigString = pr->getConfigName();
}
// Apparently tiles aren't used, so tileMeta is empty
- virtual void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {}
+ void tileMeta(int x, int y, int tx, int ty) SK_OVERRIDE {}
// Flags aren't used, so addTileFlag is empty
- virtual void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {}
+ void addTileFlag(PictureResultsWriter::TileFlags flag) SK_OVERRIDE {}
virtual void tileData(
TimerData* data,
const char format[],
@@ -241,7 +241,7 @@ public:
fStream.writeText(Json::FastWriter().write(data).c_str());
}
}
- virtual void end() SK_OVERRIDE {
+ void end() SK_OVERRIDE {
fStream.flush();
}
private:
« no previous file with comments | « tools/PictureRenderer.cpp ('k') | tools/iOSShell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698