Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: tools/skpdiff/SkDiffContext.cpp

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/skpdiff/SkCLImageDiffer.h ('k') | tools/skpdiff/SkDifferentPixelsMetric.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkImageDecoder.h" 9 #include "SkImageDecoder.h"
10 #include "SkOSFile.h" 10 #include "SkOSFile.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 class SkThreadedDiff : public SkRunnable { 212 class SkThreadedDiff : public SkRunnable {
213 public: 213 public:
214 SkThreadedDiff() : fDiffContext(NULL) { } 214 SkThreadedDiff() : fDiffContext(NULL) { }
215 215
216 void setup(SkDiffContext* diffContext, const SkString& baselinePath, const S kString& testPath) { 216 void setup(SkDiffContext* diffContext, const SkString& baselinePath, const S kString& testPath) {
217 fDiffContext = diffContext; 217 fDiffContext = diffContext;
218 fBaselinePath = baselinePath; 218 fBaselinePath = baselinePath;
219 fTestPath = testPath; 219 fTestPath = testPath;
220 } 220 }
221 221
222 virtual void run() SK_OVERRIDE { 222 void run() SK_OVERRIDE {
223 fDiffContext->addDiff(fBaselinePath.c_str(), fTestPath.c_str()); 223 fDiffContext->addDiff(fBaselinePath.c_str(), fTestPath.c_str());
224 } 224 }
225 225
226 private: 226 private:
227 SkDiffContext* fDiffContext; 227 SkDiffContext* fDiffContext;
228 SkString fBaselinePath; 228 SkString fBaselinePath;
229 SkString fTestPath; 229 SkString fTestPath;
230 }; 230 };
231 231
232 void SkDiffContext::diffDirectories(const char baselinePath[], const char testPa th[]) { 232 void SkDiffContext::diffDirectories(const char baselinePath[], const char testPa th[]) {
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 for (int i = 0; i < cntColumns; i++) { 452 for (int i = 0; i < cntColumns; i++) {
453 SkString str; 453 SkString str;
454 str.printf(", %f", values[i]); 454 str.printf(", %f", values[i]);
455 stream.writeText(str.c_str()); 455 stream.writeText(str.c_str());
456 } 456 }
457 stream.writeText("\n"); 457 stream.writeText("\n");
458 458
459 currentRecord = iter2.next(); 459 currentRecord = iter2.next();
460 } 460 }
461 } 461 }
OLDNEW
« no previous file with comments | « tools/skpdiff/SkCLImageDiffer.h ('k') | tools/skpdiff/SkDifferentPixelsMetric.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698