Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: tests/RecordDrawTest.cpp

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/QuickRejectTest.cpp ('k') | tests/RecordReplaceDrawTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "Test.h" 8 #include "Test.h"
9 #include "RecordTestUtils.h" 9 #include "RecordTestUtils.h"
10 10
11 #include "SkDebugCanvas.h" 11 #include "SkDebugCanvas.h"
12 #include "SkDropShadowImageFilter.h" 12 #include "SkDropShadowImageFilter.h"
13 #include "SkImagePriv.h" 13 #include "SkImagePriv.h"
14 #include "SkRecord.h" 14 #include "SkRecord.h"
15 #include "SkRecordDraw.h" 15 #include "SkRecordDraw.h"
16 #include "SkRecordOpts.h" 16 #include "SkRecordOpts.h"
17 #include "SkRecorder.h" 17 #include "SkRecorder.h"
18 #include "SkRecords.h" 18 #include "SkRecords.h"
19 #include "SkSurface.h" 19 #include "SkSurface.h"
20 20
21 static const int W = 1920, H = 1080; 21 static const int W = 1920, H = 1080;
22 22
23 class JustOneDraw : public SkPicture::AbortCallback { 23 class JustOneDraw : public SkPicture::AbortCallback {
24 public: 24 public:
25 JustOneDraw() : fCalls(0) {} 25 JustOneDraw() : fCalls(0) {}
26 26
27 virtual bool abort() SK_OVERRIDE { return fCalls++ > 0; } 27 bool abort() SK_OVERRIDE { return fCalls++ > 0; }
28 private: 28 private:
29 int fCalls; 29 int fCalls;
30 }; 30 };
31 31
32 DEF_TEST(RecordDraw_LazySaves, r) { 32 DEF_TEST(RecordDraw_LazySaves, r) {
33 // Record two commands. 33 // Record two commands.
34 SkRecord record; 34 SkRecord record;
35 SkRecorder recorder(&record, W, H); 35 SkRecorder recorder(&record, W, H);
36 36
37 REPORTER_ASSERT(r, 0 == record.count()); 37 REPORTER_ASSERT(r, 0 == record.count());
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 0); 116 setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 0);
117 REPORTER_ASSERT(r, setMatrix->matrix == translate); 117 REPORTER_ASSERT(r, setMatrix->matrix == translate);
118 118
119 setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 2); 119 setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 2);
120 SkMatrix expected = scale; 120 SkMatrix expected = scale;
121 expected.postConcat(translate); 121 expected.postConcat(translate);
122 REPORTER_ASSERT(r, setMatrix->matrix == expected); 122 REPORTER_ASSERT(r, setMatrix->matrix == expected);
123 } 123 }
124 124
125 struct TestBBH : public SkBBoxHierarchy { 125 struct TestBBH : public SkBBoxHierarchy {
126 virtual void insert(SkAutoTMalloc<SkRect>* boundsArray, int N) SK_OVERRIDE { 126 void insert(SkAutoTMalloc<SkRect>* boundsArray, int N) SK_OVERRIDE {
127 fEntries.setCount(N); 127 fEntries.setCount(N);
128 for (int i = 0; i < N; i++) { 128 for (int i = 0; i < N; i++) {
129 Entry e = { (unsigned)i, (*boundsArray)[i] }; 129 Entry e = { (unsigned)i, (*boundsArray)[i] };
130 fEntries[i] = e; 130 fEntries[i] = e;
131 } 131 }
132 } 132 }
133 133
134 virtual void search(const SkRect& query, SkTDArray<unsigned>* results) const SK_OVERRIDE {} 134 void search(const SkRect& query, SkTDArray<unsigned>* results) const SK_OVER RIDE {}
135 virtual size_t bytesUsed() const SK_OVERRIDE { return 0; } 135 size_t bytesUsed() const SK_OVERRIDE { return 0; }
136 136
137 struct Entry { 137 struct Entry {
138 unsigned opIndex; 138 unsigned opIndex;
139 SkRect bounds; 139 SkRect bounds;
140 }; 140 };
141 SkTDArray<Entry> fEntries; 141 SkTDArray<Entry> fEntries;
142 }; 142 };
143 143
144 // Like a==b, with a little slop recognizing that float equality can be weird. 144 // Like a==b, with a little slop recognizing that float equality can be weird.
145 static bool sloppy_rect_eq(SkRect a, SkRect b) { 145 static bool sloppy_rect_eq(SkRect a, SkRect b) {
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 323
324 { 324 {
325 SkRecord record; 325 SkRecord record;
326 SkRecorder recorder(&record, 10, 10); 326 SkRecorder recorder(&record, 10, 10);
327 recorder.drawImageRect(image, 0, SkRect::MakeWH(10, 10)); 327 recorder.drawImageRect(image, 0, SkRect::MakeWH(10, 10));
328 SkRecordDraw(record, &canvas, NULL, NULL, 0, NULL, 0); 328 SkRecordDraw(record, &canvas, NULL, NULL, 0, NULL, 0);
329 } 329 }
330 REPORTER_ASSERT(r, canvas.fDrawImageRectCalled); 330 REPORTER_ASSERT(r, canvas.fDrawImageRectCalled);
331 331
332 } 332 }
OLDNEW
« no previous file with comments | « tests/QuickRejectTest.cpp ('k') | tests/RecordReplaceDrawTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698