Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/gpu/gl/GrGLRenderTarget.h

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/gl/GrGLProgram.h ('k') | src/gpu/gl/GrGLStencilBuffer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #ifndef GrGLRenderTarget_DEFINED 9 #ifndef GrGLRenderTarget_DEFINED
10 #define GrGLRenderTarget_DEFINED 10 #define GrGLRenderTarget_DEFINED
(...skipping 24 matching lines...) Expand all
35 35
36 // The following two functions return the same ID when a 36 // The following two functions return the same ID when a
37 // texture/render target is multisampled, and different IDs when 37 // texture/render target is multisampled, and different IDs when
38 // it is. 38 // it is.
39 // FBO ID used to render into 39 // FBO ID used to render into
40 GrGLuint renderFBOID() const { return fRTFBOID; } 40 GrGLuint renderFBOID() const { return fRTFBOID; }
41 // FBO ID that has texture ID attached. 41 // FBO ID that has texture ID attached.
42 GrGLuint textureFBOID() const { return fTexFBOID; } 42 GrGLuint textureFBOID() const { return fTexFBOID; }
43 43
44 // override of GrRenderTarget 44 // override of GrRenderTarget
45 virtual GrBackendObject getRenderTargetHandle() const SK_OVERRIDE { return t his->renderFBOID(); } 45 GrBackendObject getRenderTargetHandle() const SK_OVERRIDE { return this->ren derFBOID(); }
46 virtual GrBackendObject getRenderTargetResolvedHandle() const SK_OVERRIDE { return this->textureFBOID(); } 46 GrBackendObject getRenderTargetResolvedHandle() const SK_OVERRIDE { return t his->textureFBOID(); }
47 virtual ResolveType getResolveType() const SK_OVERRIDE { 47 ResolveType getResolveType() const SK_OVERRIDE {
48 if (!this->isMultisampled() || 48 if (!this->isMultisampled() ||
49 fRTFBOID == fTexFBOID) { 49 fRTFBOID == fTexFBOID) {
50 // catches FBO 0 and non MSAA case 50 // catches FBO 0 and non MSAA case
51 return kAutoResolves_ResolveType; 51 return kAutoResolves_ResolveType;
52 } else if (kUnresolvableFBOID == fTexFBOID) { 52 } else if (kUnresolvableFBOID == fTexFBOID) {
53 return kCantResolve_ResolveType; 53 return kCantResolve_ResolveType;
54 } else { 54 } else {
55 return kCanResolve_ResolveType; 55 return kCanResolve_ResolveType;
56 } 56 }
57 } 57 }
58 58
59 protected: 59 protected:
60 // The public constructor registers this object with the cache. However, onl y the most derived 60 // The public constructor registers this object with the cache. However, onl y the most derived
61 // class should register with the cache. This constructor does not do the re gistration and 61 // class should register with the cache. This constructor does not do the re gistration and
62 // rather moves that burden onto the derived class. 62 // rather moves that burden onto the derived class.
63 enum Derived { kDerived }; 63 enum Derived { kDerived };
64 GrGLRenderTarget(GrGLGpu*, const GrSurfaceDesc&, const IDDesc&, Derived); 64 GrGLRenderTarget(GrGLGpu*, const GrSurfaceDesc&, const IDDesc&, Derived);
65 65
66 void init(const GrSurfaceDesc&, const IDDesc&); 66 void init(const GrSurfaceDesc&, const IDDesc&);
67 67
68 virtual void onAbandon() SK_OVERRIDE; 68 void onAbandon() SK_OVERRIDE;
69 virtual void onRelease() SK_OVERRIDE; 69 void onRelease() SK_OVERRIDE;
70 70
71 // In protected because subclass GrGLTextureRenderTarget calls this version. 71 // In protected because subclass GrGLTextureRenderTarget calls this version.
72 virtual size_t onGpuMemorySize() const SK_OVERRIDE; 72 size_t onGpuMemorySize() const SK_OVERRIDE;
73 73
74 private: 74 private:
75 GrGLuint fRTFBOID; 75 GrGLuint fRTFBOID;
76 GrGLuint fTexFBOID; 76 GrGLuint fTexFBOID;
77 GrGLuint fMSColorRenderbufferID; 77 GrGLuint fMSColorRenderbufferID;
78 78
79 // We track this separately from GrGpuResource because this may be both a te xture and a render 79 // We track this separately from GrGpuResource because this may be both a te xture and a render
80 // target, and the texture may be wrapped while the render target is not. 80 // target, and the texture may be wrapped while the render target is not.
81 bool fIsWrapped; 81 bool fIsWrapped;
82 82
83 // when we switch to this render target we want to set the viewport to 83 // when we switch to this render target we want to set the viewport to
84 // only render to content area (as opposed to the whole allocation) and 84 // only render to content area (as opposed to the whole allocation) and
85 // we want the rendering to be at top left (GL has origin in bottom left) 85 // we want the rendering to be at top left (GL has origin in bottom left)
86 GrGLIRect fViewport; 86 GrGLIRect fViewport;
87 87
88 // onGpuMemorySize() needs to know what how many color values are owned per pixel. However, 88 // onGpuMemorySize() needs to know what how many color values are owned per pixel. However,
89 // abandon and release zero out the IDs and the cache needs to know the size even after those 89 // abandon and release zero out the IDs and the cache needs to know the size even after those
90 // actions. 90 // actions.
91 uint8_t fColorValuesPerPixel; 91 uint8_t fColorValuesPerPixel;
92 92
93 typedef GrRenderTarget INHERITED; 93 typedef GrRenderTarget INHERITED;
94 }; 94 };
95 95
96 #endif 96 #endif
OLDNEW
« no previous file with comments | « src/gpu/gl/GrGLProgram.h ('k') | src/gpu/gl/GrGLStencilBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698