Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: src/gpu/effects/GrConfigConversionEffect.h

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/effects/GrBitmapTextGeoProc.cpp ('k') | src/gpu/effects/GrConvexPolyEffect.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrConfigConversionEffect_DEFINED 8 #ifndef GrConfigConversionEffect_DEFINED
9 #define GrConfigConversionEffect_DEFINED 9 #define GrConfigConversionEffect_DEFINED
10 10
(...skipping 19 matching lines...) Expand all
30 kMulByAlpha_RoundDown_PMConversion, 30 kMulByAlpha_RoundDown_PMConversion,
31 kDivByAlpha_RoundUp_PMConversion, 31 kDivByAlpha_RoundUp_PMConversion,
32 kDivByAlpha_RoundDown_PMConversion, 32 kDivByAlpha_RoundDown_PMConversion,
33 33
34 kPMConversionCnt 34 kPMConversionCnt
35 }; 35 };
36 36
37 static const GrFragmentProcessor* Create(GrTexture*, bool swapRedAndBlue, PM Conversion, 37 static const GrFragmentProcessor* Create(GrTexture*, bool swapRedAndBlue, PM Conversion,
38 const SkMatrix&); 38 const SkMatrix&);
39 39
40 virtual const char* name() const SK_OVERRIDE { return "Config Conversion"; } 40 const char* name() const SK_OVERRIDE { return "Config Conversion"; }
41 41
42 virtual void getGLProcessorKey(const GrGLCaps&, GrProcessorKeyBuilder*) cons t SK_OVERRIDE; 42 void getGLProcessorKey(const GrGLCaps&, GrProcessorKeyBuilder*) const SK_OVE RRIDE;
43 43
44 virtual GrGLFragmentProcessor* createGLInstance() const SK_OVERRIDE; 44 GrGLFragmentProcessor* createGLInstance() const SK_OVERRIDE;
45 45
46 bool swapsRedAndBlue() const { return fSwapRedAndBlue; } 46 bool swapsRedAndBlue() const { return fSwapRedAndBlue; }
47 PMConversion pmConversion() const { return fPMConversion; } 47 PMConversion pmConversion() const { return fPMConversion; }
48 48
49 // This function determines whether it is possible to choose PM->UPM and UPM ->PM conversions 49 // This function determines whether it is possible to choose PM->UPM and UPM ->PM conversions
50 // for which in any PM->UPM->PM->UPM sequence the two UPM values are the sam e. This means that 50 // for which in any PM->UPM->PM->UPM sequence the two UPM values are the sam e. This means that
51 // if pixels are read back to a UPM buffer, written back to PM to the GPU, a nd read back again 51 // if pixels are read back to a UPM buffer, written back to PM to the GPU, a nd read back again
52 // both reads will produce the same result. This test is quite expensive and should not be run 52 // both reads will produce the same result. This test is quite expensive and should not be run
53 // multiple times for a given context. 53 // multiple times for a given context.
54 static void TestForPreservingPMConversions(GrContext* context, 54 static void TestForPreservingPMConversions(GrContext* context,
55 PMConversion* PMToUPMRule, 55 PMConversion* PMToUPMRule,
56 PMConversion* UPMToPMRule); 56 PMConversion* UPMToPMRule);
57 57
58 private: 58 private:
59 GrConfigConversionEffect(GrTexture*, 59 GrConfigConversionEffect(GrTexture*,
60 bool swapRedAndBlue, 60 bool swapRedAndBlue,
61 PMConversion pmConversion, 61 PMConversion pmConversion,
62 const SkMatrix& matrix); 62 const SkMatrix& matrix);
63 63
64 virtual bool onIsEqual(const GrFragmentProcessor&) const SK_OVERRIDE; 64 bool onIsEqual(const GrFragmentProcessor&) const SK_OVERRIDE;
65 65
66 virtual void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVE RRIDE; 66 void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVERRIDE;
67 67
68 bool fSwapRedAndBlue; 68 bool fSwapRedAndBlue;
69 PMConversion fPMConversion; 69 PMConversion fPMConversion;
70 70
71 GR_DECLARE_FRAGMENT_PROCESSOR_TEST; 71 GR_DECLARE_FRAGMENT_PROCESSOR_TEST;
72 72
73 typedef GrSingleTextureEffect INHERITED; 73 typedef GrSingleTextureEffect INHERITED;
74 }; 74 };
75 75
76 #endif 76 #endif
OLDNEW
« no previous file with comments | « src/gpu/effects/GrBitmapTextGeoProc.cpp ('k') | src/gpu/effects/GrConvexPolyEffect.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698