Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Side by Side Diff: dm/DMPipeTask.h

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « dm/DMPDFTask.h ('k') | dm/DMQuiltTask.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #ifndef DMPipeTask_DEFINED 1 #ifndef DMPipeTask_DEFINED
2 #define DMPipeTask_DEFINED 2 #define DMPipeTask_DEFINED
3 3
4 #include "DMTask.h" 4 #include "DMTask.h"
5 #include "SkBitmap.h" 5 #include "SkBitmap.h"
6 #include "SkString.h" 6 #include "SkString.h"
7 #include "SkTemplates.h" 7 #include "SkTemplates.h"
8 #include "gm.h" 8 #include "gm.h"
9 9
10 // Sends a GM through a pipe, draws it, and compares against the reference bitma p. 10 // Sends a GM through a pipe, draws it, and compares against the reference bitma p.
11 11
12 namespace DM { 12 namespace DM {
13 13
14 class PipeTask : public CpuTask { 14 class PipeTask : public CpuTask {
15 15
16 public: 16 public:
17 enum Mode { 17 enum Mode {
18 kInProcess_Mode, 18 kInProcess_Mode,
19 kCrossProcess_Mode, 19 kCrossProcess_Mode,
20 kSharedAddress_Mode, 20 kSharedAddress_Mode,
21 }; 21 };
22 22
23 PipeTask(const Task& parent, // PipeTask must be a child task. Pass its parent here. 23 PipeTask(const Task& parent, // PipeTask must be a child task. Pass its parent here.
24 skiagm::GM*, // GM to run through a pipe. Takes owne rship. 24 skiagm::GM*, // GM to run through a pipe. Takes owne rship.
25 SkBitmap reference, // Bitmap to compare pipe results to. 25 SkBitmap reference, // Bitmap to compare pipe results to.
26 Mode); 26 Mode);
27 27
28 virtual void draw() SK_OVERRIDE; 28 void draw() SK_OVERRIDE;
29 virtual bool shouldSkip() const SK_OVERRIDE; 29 bool shouldSkip() const SK_OVERRIDE;
30 virtual SkString name() const SK_OVERRIDE { return fName; } 30 SkString name() const SK_OVERRIDE { return fName; }
31 31
32 private: 32 private:
33 const uint32_t fFlags; 33 const uint32_t fFlags;
34 const SkString fName; 34 const SkString fName;
35 SkAutoTDelete<skiagm::GM> fGM; 35 SkAutoTDelete<skiagm::GM> fGM;
36 const SkBitmap fReference; 36 const SkBitmap fReference;
37 }; 37 };
38 38
39 } // namespace DM 39 } // namespace DM
40 40
41 #endif // DMPipeTask_DEFINED 41 #endif // DMPipeTask_DEFINED
OLDNEW
« no previous file with comments | « dm/DMPDFTask.h ('k') | dm/DMQuiltTask.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698