Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: bench/GeometryBench.cpp

Issue 806653007: Fix up all the easy virtual ... SK_OVERRIDE cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « bench/GameBench.cpp ('k') | bench/GrMemoryPoolBench.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "Benchmark.h" 8 #include "Benchmark.h"
9 #include "SkGeometry.h" 9 #include "SkGeometry.h"
10 #include "SkRandom.h" 10 #include "SkRandom.h"
11 #include "SkRect.h" 11 #include "SkRect.h"
12 12
13 class GeometryBench : public Benchmark { 13 class GeometryBench : public Benchmark {
14 public: 14 public:
15 GeometryBench(const char suffix[]) : fVolatileInt(0) { 15 GeometryBench(const char suffix[]) : fVolatileInt(0) {
16 fName.printf("geo_%s", suffix); 16 fName.printf("geo_%s", suffix);
17 } 17 }
18 18
19 virtual const char* onGetName() SK_OVERRIDE { 19 const char* onGetName() SK_OVERRIDE {
20 return fName.c_str(); 20 return fName.c_str();
21 } 21 }
22 22
23 virtual bool isSuitableFor(Backend backend) SK_OVERRIDE { 23 bool isSuitableFor(Backend backend) SK_OVERRIDE {
24 return kNonRendering_Backend == backend; 24 return kNonRendering_Backend == backend;
25 } 25 }
26 26
27 protected: 27 protected:
28 volatile int fVolatileInt; 28 volatile int fVolatileInt;
29 29
30 /** 30 /**
31 * Subclasses can call this to try to defeat the optimizer (with some resul t of their 31 * Subclasses can call this to try to defeat the optimizer (with some resul t of their
32 * inner loop), since it will fool the compiler into assuming that "n" is a ctually 32 * inner loop), since it will fool the compiler into assuming that "n" is a ctually
33 * needed somewhere, and since this method is not const, the member fields cannot 33 * needed somewhere, and since this method is not const, the member fields cannot
(...skipping 24 matching lines...) Expand all
58 fRects[i].setXYWH(x, y, w, h); 58 fRects[i].setXYWH(x, y, w, h);
59 } 59 }
60 } 60 }
61 }; 61 };
62 62
63 class GeoRectBench_intersect : public GeoRectBench { 63 class GeoRectBench_intersect : public GeoRectBench {
64 public: 64 public:
65 GeoRectBench_intersect() : GeoRectBench("rect_intersect") {} 65 GeoRectBench_intersect() : GeoRectBench("rect_intersect") {}
66 66
67 protected: 67 protected:
68 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { 68 void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
69 for (int outer = 0; outer < loops; ++outer) { 69 for (int outer = 0; outer < loops; ++outer) {
70 int count = 0; 70 int count = 0;
71 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) { 71 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) {
72 SkRect r = fRects[0]; 72 SkRect r = fRects[0];
73 count += r.intersect(fRects[i]); 73 count += r.intersect(fRects[i]);
74 } 74 }
75 this->virtualCallToFoilOptimizers(count); 75 this->virtualCallToFoilOptimizers(count);
76 } 76 }
77 } 77 }
78 }; 78 };
79 79
80 class GeoRectBench_intersect_rect : public GeoRectBench { 80 class GeoRectBench_intersect_rect : public GeoRectBench {
81 public: 81 public:
82 GeoRectBench_intersect_rect() : GeoRectBench("rect_intersect_rect") {} 82 GeoRectBench_intersect_rect() : GeoRectBench("rect_intersect_rect") {}
83 83
84 protected: 84 protected:
85 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { 85 void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
86 for (int outer = 0; outer < loops; ++outer) { 86 for (int outer = 0; outer < loops; ++outer) {
87 int count = 0; 87 int count = 0;
88 SkRect r; 88 SkRect r;
89 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) { 89 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) {
90 count += r.intersect(fRects[0], fRects[i]); 90 count += r.intersect(fRects[0], fRects[i]);
91 } 91 }
92 this->virtualCallToFoilOptimizers(count); 92 this->virtualCallToFoilOptimizers(count);
93 } 93 }
94 } 94 }
95 }; 95 };
96 96
97 class GeoRectBench_Intersects : public GeoRectBench { 97 class GeoRectBench_Intersects : public GeoRectBench {
98 public: 98 public:
99 GeoRectBench_Intersects() : GeoRectBench("rect_Intersects") {} 99 GeoRectBench_Intersects() : GeoRectBench("rect_Intersects") {}
100 100
101 protected: 101 protected:
102 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { 102 void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
103 for (int outer = 0; outer < loops; ++outer) { 103 for (int outer = 0; outer < loops; ++outer) {
104 int count = 0; 104 int count = 0;
105 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) { 105 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) {
106 count += SkRect::Intersects(fRects[0], fRects[i]); 106 count += SkRect::Intersects(fRects[0], fRects[i]);
107 } 107 }
108 this->virtualCallToFoilOptimizers(count); 108 this->virtualCallToFoilOptimizers(count);
109 } 109 }
110 } 110 }
111 }; 111 };
112 112
113 class GeoRectBench_sort : public GeoRectBench { 113 class GeoRectBench_sort : public GeoRectBench {
114 public: 114 public:
115 GeoRectBench_sort() : GeoRectBench("rect_sort") {} 115 GeoRectBench_sort() : GeoRectBench("rect_sort") {}
116 116
117 protected: 117 protected:
118 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { 118 void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
119 for (int outer = 0; outer < loops; ++outer) { 119 for (int outer = 0; outer < loops; ++outer) {
120 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) { 120 for (size_t i = 0; i < SK_ARRAY_COUNT(fRects); ++i) {
121 fRects[i].sort(); 121 fRects[i].sort();
122 } 122 }
123 } 123 }
124 } 124 }
125 }; 125 };
126 126
127 DEF_BENCH( return new GeoRectBench_intersect; ) 127 DEF_BENCH( return new GeoRectBench_intersect; )
128 DEF_BENCH( return new GeoRectBench_intersect_rect; ) 128 DEF_BENCH( return new GeoRectBench_intersect_rect; )
129 DEF_BENCH( return new GeoRectBench_Intersects; ) 129 DEF_BENCH( return new GeoRectBench_Intersects; )
130 130
131 DEF_BENCH( return new GeoRectBench_sort; ) 131 DEF_BENCH( return new GeoRectBench_sort; )
OLDNEW
« no previous file with comments | « bench/GameBench.cpp ('k') | bench/GrMemoryPoolBench.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698