content/common/gpu/client/gpu_memory_buffer_impl.h - Issue 806653006: Update GPU memory buffers to use StrideInBytes internally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl.h

Issue 806653006: Update GPU memory buffers to use StrideInBytes internally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use CheckedNumeric Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl.cc » ('j') | content/common/gpu/client/gpu_memory_buffer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl.h b/content/common/gpu/client/gpu_memory_buffer_impl.h

index dc792246e1fac1d29d2f02271b5dc03735b37d90..dae9c8dc816eed3c4131a24a5b7b392920d9679b 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl.h

@@ -33,9 +33,11 @@ class CONTENT_EXPORT GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {

// Type-checking upcast routine. Returns an NULL on failure.

static GpuMemoryBufferImpl* FromClientBuffer(ClientBuffer buffer);

- // Returns the number of bytes per pixel that must be used by an

- // implementation when using |format|.

- static size_t BytesPerPixel(Format format);

+ // Calculates the number of bytes that an implementation must use to store

+ // one row of pixel data.

+ static bool StrideInBytes(size_t width,

+ Format format,

+ size_t* stride_in_bytes);

// Overridden from gfx::GpuMemoryBuffer:

bool IsMapped() const override;