content/common/gpu/client/gpu_memory_buffer_impl.cc - Issue 806653006: Update GPU memory buffers to use StrideInBytes internally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl.cc

Issue 806653006: Update GPU memory buffers to use StrideInBytes internally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use StrideInBytes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl.h ('k') | content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc » ('j') | content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl.cc b/content/common/gpu/client/gpu_memory_buffer_impl.cc

index d3c08bdb1a09b0d1256c297148cd190d2fae5690..e02109054071dd41bdadeadfd5d167f5df50757f 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl.cc

@@ -76,12 +76,12 @@ GpuMemoryBufferImpl* GpuMemoryBufferImpl::FromClientBuffer(

}

// static

-size_t GpuMemoryBufferImpl::BytesPerPixel(Format format) {

+size_t GpuMemoryBufferImpl::StrideInBytes(size_t width, Format format) {

reveman 2014/12/18 18:49:56 I think this needs to be using CheckedNumeric. See

christiank 2015/01/12 10:35:22 Agreed, it's now updated to use CheckedNumeric.

switch (format) {

case RGBA_8888:

case RGBX_8888:

case BGRA_8888:

- return 4;

+ return width * 4;

}

NOTREACHED();