Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: ui/gl/gl_image_shared_memory.cc

Issue 806653006: Update GPU memory buffers to use StrideInBytes internally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/gl_image_memory.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_image_shared_memory.h" 5 #include "ui/gl/gl_image_shared_memory.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/numerics/safe_math.h" 8 #include "base/numerics/safe_math.h"
9 #include "base/process/process_handle.h" 9 #include "base/process/process_handle.h"
10 10
11 namespace gfx { 11 namespace gfx {
12 namespace { 12 namespace {
13 13
14 // Returns true if the size is valid and false otherwise. 14 // Returns true if the size is valid and false otherwise.
15 bool SizeInBytes(const gfx::Size& size, 15 bool SizeInBytes(const gfx::Size& size,
16 gfx::GpuMemoryBuffer::Format format, 16 gfx::GpuMemoryBuffer::Format format,
17 size_t* size_in_bytes) { 17 size_t* size_in_bytes) {
18 if (size.IsEmpty()) 18 if (size.IsEmpty())
19 return false; 19 return false;
20 base::CheckedNumeric<size_t> s = GLImageMemory::BytesPerPixel(format); 20
21 s *= size.width(); 21 size_t stride_in_bytes = 0;
22 if (!GLImageMemory::StrideInBytes(size.width(), format, &stride_in_bytes))
23 return false;
24 base::CheckedNumeric<size_t> s = stride_in_bytes;
22 s *= size.height(); 25 s *= size.height();
23 if (!s.IsValid()) 26 if (!s.IsValid())
24 return false; 27 return false;
25 *size_in_bytes = s.ValueOrDie(); 28 *size_in_bytes = s.ValueOrDie();
26 return true; 29 return true;
27 } 30 }
28 31
29 } // namespace 32 } // namespace
30 33
31 GLImageSharedMemory::GLImageSharedMemory(const gfx::Size& size, 34 GLImageSharedMemory::GLImageSharedMemory(const gfx::Size& size,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 shared_memory_ = duped_shared_memory.Pass(); 75 shared_memory_ = duped_shared_memory.Pass();
73 return true; 76 return true;
74 } 77 }
75 78
76 void GLImageSharedMemory::Destroy(bool have_context) { 79 void GLImageSharedMemory::Destroy(bool have_context) {
77 GLImageMemory::Destroy(have_context); 80 GLImageMemory::Destroy(have_context);
78 shared_memory_.reset(); 81 shared_memory_.reset();
79 } 82 }
80 83
81 } // namespace gfx 84 } // namespace gfx
OLDNEW
« no previous file with comments | « ui/gl/gl_image_memory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698