Chromium Code Reviews Chromium Code Reviews
Issue 806633003:
Implement basic toolbar with Material Design and loading progress. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/pdf/index-material.html |
| diff --git a/chrome/browser/resources/pdf/index-material.html b/chrome/browser/resources/pdf/index-material.html |
| index 6d0b43abc7afdd4b3c126136da4c08ee0d269af4..246f1d9111b25a07bd2144f8e86d7340fd003301 100644 |
| --- a/chrome/browser/resources/pdf/index-material.html |
| +++ b/chrome/browser/resources/pdf/index-material.html |
| @@ -7,17 +7,35 @@ |
| <link rel="import" href="html_office/elements/viewer-error-screen/viewer-error-screen.html"> |
| <link rel="import" href="html_office/elements/viewer-page-indicator/viewer-page-indicator.html"> |
| <link rel="import" href="html_office/elements/viewer-password-screen/viewer-password-screen.html"> |
| - <link rel="import" href="html_office/elements/viewer-progress-bar/viewer-progress-bar.html"> |
| <link rel="import" href="html_office/elements/viewer-toolbar/viewer-toolbar.html"> |
| <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| <link rel="stylesheet" type="text/css" href="index.css"> |
| + |
| + <link rel="import" href="chrome://resources/polymer/core-icons/core-icons.html"> |
|
raymes
2015/01/09 04:15:09
Do we need this?
Alexandre Carlton
2015/01/12 06:33:57
Removed.
|
| + <link rel="import" href="chrome://resources/polymer/core-toolbar/core-toolbar.html"> |
| + <link rel="import" href="chrome://resources/polymer/paper-icon-button/paper-icon-button.html"> |
| + <link rel="import" href="chrome://resources/polymer/paper-progress/paper-progress.html"> |
| + <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.html"> |
| + |
| + <!-- Font Roboto is not included in chrome://resources, so this is a temporary workaround. --> |
|
raymes
2015/01/09 04:15:09
Can we add it to chrome://resources? It looks like
Alexandre Carlton
2015/01/12 06:33:56
See Issue 846833002.
|
| + <link href="http://fonts.googleapis.com/css?family=RobotoDraft:regular,bold,italic,thin,light,bolditalic,black,medium&lang=en" rel="stylesheet" type="text/css"> |
| </head> |
| <body> |
| +<paper-shadow id="toolbar-shadow" z="1"> |
|
raymes
2015/01/09 04:15:09
nit: only add ids to things that need to be refere
Alexandre Carlton
2015/01/12 06:33:57
We need to set the position and width of this part
|
| + <core-toolbar id="pdf-toolbar"> |
|
raymes
2015/01/09 04:15:09
maybe just id="toolbar"
Alexandre Carlton
2015/01/12 06:33:57
The viewer-toolbar currently has an id of "toolbar
|
| + <span flex id="title">PDF Viewer</span> |
| + |
| + <paper-icon-button icon="file-download" id="save-button"></paper-icon-button> |
| + |
| + <paper-icon-button icon="print" id="print-button"></paper-icon-button> |
| + |
| + <paper-progress value="0" class="bottom fit" id="progress-bar"></paper-progress> |
| + </core-toolbar> |
| +</paper-shadow> |
| <div id="sizer"></div> |
| <viewer-password-screen id="password-screen"></viewer-password-screen> |
| <viewer-page-indicator id="page-indicator"></viewer-page-indicator> |
| -<viewer-progress-bar id="progress-bar"></viewer-progress-bar> |
| <viewer-toolbar id="toolbar"> |
| <viewer-button id="fit-to-page-button" |
| @@ -36,14 +54,6 @@ |
| assetpath="html_office/elements/viewer-button/" |
| img="button_zoom_in.png"> |
| </viewer-button> |
| - <viewer-button id="save-button" |
| - assetpath="html_office/elements/viewer-button/" |
| - img="button_save.png"> |
| - </viewer-button> |
| - <viewer-button id="print-button" |
| - assetpath="html_office/elements/viewer-button/" |
| - img="button_print.png"> |
| - </viewer-button> |
| </viewer-toolbar> |
| <viewer-error-screen id="error-screen"></viewer-error-screen> |
