Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 806553004: Fix inclusion of SkDrawPictureCallback.h (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inclusion of SkDrawPictureCallback.h SkDrawPictureCallback is going to be renamed (https://codereview.chromium.org/837693002/). This CL updates the includes to stage the transition. Committed: https://crrev.com/90334831a0069cee46abf26a0ed2b04a25a498d8 Cr-Commit-Position: refs/heads/master@{#310119}

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M cc/resources/drawing_display_item.cc View 1 chunk +1 line, -0 lines 2 comments Download
M cc/resources/picture.h View 1 chunk +1 line, -0 lines 1 comment Download
M cc/resources/picture.cc View 1 chunk +1 line, -0 lines 2 comments Download
M skia/ext/analysis_canvas.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
robertphillips
5 years, 11 months ago (2015-01-06 15:37:37 UTC) #2
danakj
https://codereview.chromium.org/806553004/diff/20001/cc/resources/drawing_display_item.cc File cc/resources/drawing_display_item.cc (right): https://codereview.chromium.org/806553004/diff/20001/cc/resources/drawing_display_item.cc#newcode8 cc/resources/drawing_display_item.cc:8: #include "third_party/skia/include/core/SkDrawPictureCallback.h" A forward declaration seems like enough here? ...
5 years, 11 months ago (2015-01-06 15:42:46 UTC) #4
robertphillips
https://codereview.chromium.org/806553004/diff/20001/cc/resources/drawing_display_item.cc File cc/resources/drawing_display_item.cc (right): https://codereview.chromium.org/806553004/diff/20001/cc/resources/drawing_display_item.cc#newcode8 cc/resources/drawing_display_item.cc:8: #include "third_party/skia/include/core/SkDrawPictureCallback.h" This include will go away after the ...
5 years, 11 months ago (2015-01-06 16:08:09 UTC) #5
danakj
I see, thanks. LGTM
5 years, 11 months ago (2015-01-06 16:11:30 UTC) #6
robertphillips
5 years, 11 months ago (2015-01-06 17:43:38 UTC) #8
f(malita)
skia/ lgtm
5 years, 11 months ago (2015-01-06 17:46:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806553004/20001
5 years, 11 months ago (2015-01-06 17:47:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 20:03:15 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 20:04:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90334831a0069cee46abf26a0ed2b04a25a498d8
Cr-Commit-Position: refs/heads/master@{#310119}

Powered by Google App Engine
This is Rietveld 408576698