Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 806533003: android: don't export unnecessary symbols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | mojo/mojo_public_gles2_for_loadable_module.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 584f72be2e30c6277aa04d6d005b788137e55d06..1460fb3eb1eb955b9fc32ae3c9306018d372d071 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -449,8 +449,15 @@ config("compiler") {
ldflags += [
"-Wl,--no-undefined",
- # Don't export symbols from statically linked libraries.
- "-Wl,--exclude-libs=ALL",
+ # Don't allow visible symbols from libgcc or stlport to be
+ # re-exported.
+ "-Wl,--exclude-libs=libgcc.a",
+ "-Wl,--exclude-libs=libstlport_static.a",
+
+ # Don't allow visible symbols from libraries that contain
+ # assembly code with symbols that aren't hidden properly.
+ # http://crbug.com/448386
+ "-Wl,--exclude-libs=libvpx_assembly_arm.a",
]
if (cpu_arch == "arm") {
ldflags += [
« no previous file with comments | « build/common.gypi ('k') | mojo/mojo_public_gles2_for_loadable_module.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698