Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 806513004: Add a simple fetch API test. (Closed)

Created:
6 years ago by yhirano
Modified:
6 years ago
Reviewers:
hiroshige
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a simple fetch API test. It turns out that PRESUBMIT.py has a bug, so this CL fixes it, too. BUG=None R=hiroshige@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187525

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M LayoutTests/http/tests/fetch/PRESUBMIT.py View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/fetch/README View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/resources/hello.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/simple.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/fetch/simple.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/simple.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
yhirano
6 years ago (2014-12-19 04:23:26 UTC) #1
hiroshige
https://codereview.chromium.org/806513004/diff/1/LayoutTests/http/tests/fetch/script-tests/simple.js File LayoutTests/http/tests/fetch/script-tests/simple.js (right): https://codereview.chromium.org/806513004/diff/1/LayoutTests/http/tests/fetch/script-tests/simple.js#newcode9 LayoutTests/http/tests/fetch/script-tests/simple.js:9: }).then(function(res) { Indent +2 spaces. https://codereview.chromium.org/806513004/diff/1/LayoutTests/http/tests/fetch/script-tests/simple.js#newcode11 LayoutTests/http/tests/fetch/script-tests/simple.js:11: }).then(function(text) { ...
6 years ago (2014-12-19 07:41:20 UTC) #2
yhirano
https://codereview.chromium.org/806513004/diff/1/LayoutTests/http/tests/fetch/script-tests/simple.js File LayoutTests/http/tests/fetch/script-tests/simple.js (right): https://codereview.chromium.org/806513004/diff/1/LayoutTests/http/tests/fetch/script-tests/simple.js#newcode9 LayoutTests/http/tests/fetch/script-tests/simple.js:9: }).then(function(res) { On 2014/12/19 07:41:20, hiroshige wrote: > Indent ...
6 years ago (2014-12-19 09:29:08 UTC) #3
hiroshige
lgtm.
6 years ago (2014-12-19 10:05:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806513004/40001
6 years ago (2014-12-19 10:48:30 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 12:45:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187525

Powered by Google App Engine
This is Rietveld 408576698