Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 806513002: Move make_javascript_deterministic to UserStory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
index 7462a2802cf2c91c90af1228f1bbca94a2c6a566..c25911e6c5456ae5b573f095e8863b786cd93a3e 100644
--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
@@ -100,10 +100,6 @@ class PageSetSmokeTest(unittest.TestCase):
isinstance(page_set.user_agent_type, str),
msg='page_set\'s user_agent_type must have type string')
- self.assertTrue(
- isinstance(page_set.make_javascript_deterministic, bool),
- msg='page_set\'s make_javascript_deterministic must have type bool')
-
def CheckAttributesOfPageBasicAttributes(self, page):
self.assertTrue(not hasattr(page, 'disabled'))
self.assertTrue(
@@ -123,6 +119,10 @@ class PageSetSmokeTest(unittest.TestCase):
isinstance(page.startup_url, str),
msg=('page %s \'s startup_url field must have type string'
% page.display_name))
+ self.assertIsInstance(
+ page.make_javascript_deterministic, bool,
+ msg='page %s \'s make_javascript_deterministic must have type bool'
+ % page.display_name)
for l in page.labels:
self.assertTrue(
isinstance(l, str),
« no previous file with comments | « tools/telemetry/telemetry/page/shared_page_state.py ('k') | tools/telemetry/telemetry/user_story/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698