Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 806503003: Revert of Revert of Revert of Enable display list 2D canvas by default (Closed)

Created:
5 years, 11 months ago by rmcilroy
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/837123003/) Reason for revert: Reverting because this seems to have broken the Win XP Perf bot: https://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%281%29/ BUG=446915 Original issue's description: > Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/832083003/) > > Reason for revert: > Reverting did not solve the Win XP failures. > > Original issue's description: > > Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/) > > > > Reason for revert: > > WebKit XP bot has lots of LayoutTest failures and crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas. > > > > See eg: > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116 > > > > The commit log suggests --dump-render-tree is > > not affected by this change, but I don't see > > another likely culprit (unless https://src.chromium.org/viewvc/blink?view=rev&revision=187932) > > > > The failures started on: > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113 > > > > Chrome revision range: > > https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d7320f2ebdf610decdc..3a5e72899629e0c8d254109707e747742686fbca > > > > Blink revision range: > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=187921%3A187936&mode=html > > > > Original issue's description: > > > Enable display list 2D canvas by default > > > > > > With this change, display list 2D canvas will become enabled by > > > default in Chrome. Content shell with --dump-render-tree will > > > continue to have display lists disabled by default. > > > Currently, having display lists enabled in blink means > > > that display lists will be used whenever 2d canvases would > > > not be GPU-accelerated. > > > > > > BUG=386601 > > > > > > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae > > > Cr-Commit-Position: refs/heads/master@{#309453} > > > > TBR=avi@chromium.org,junov@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=386601 > > > > Committed: https://crrev.com/b314d341e5c60c03aa118e96318d54a84f00b053 > > Cr-Commit-Position: refs/heads/master@{#310252} > > TBR=avi@chromium.org,junov@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=386601 > > Committed: https://crrev.com/b95bb640426d6e875421462efd6715f4a10488b1 > Cr-Commit-Position: refs/heads/master@{#310265} TBR=avi@chromium.org,junov@chromium.org,falken@chromium.org NOTREECHECKS=true NOTRY=true BUG=386601 Committed: https://crrev.com/332a67f090516a637f242c60a0c8f784c4192b18 Cr-Commit-Position: refs/heads/master@{#310501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/child/runtime_features.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
Created Revert of Revert of Revert of Enable display list 2D canvas by default
5 years, 11 months ago (2015-01-08 14:44:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806503003/1
5 years, 11 months ago (2015-01-08 14:45:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 14:46:42 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/332a67f090516a637f242c60a0c8f784c4192b18 Cr-Commit-Position: refs/heads/master@{#310501}
5 years, 11 months ago (2015-01-08 14:47:38 UTC) #4
Justin Novosad
5 years, 11 months ago (2015-01-08 20:16:06 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/801443005/ by junov@chromium.org.

The reason for reverting is: Undoing revert because the reason for reverting was
resolved by http://src.chromium.org/viewvc/blink?view=rev&rev=188069.

Powered by Google App Engine
This is Rietveld 408576698