DescriptionRevert of Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/837123003/)
Reason for revert:
Reverting because this seems to have broken the Win XP Perf bot: https://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%281%29/
BUG=446915
Original issue's description:
> Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/832083003/)
>
> Reason for revert:
> Reverting did not solve the Win XP failures.
>
> Original issue's description:
> > Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/)
> >
> > Reason for revert:
> > WebKit XP bot has lots of LayoutTest failures and crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas.
> >
> > See eg:
> > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116
> >
> > The commit log suggests --dump-render-tree is
> > not affected by this change, but I don't see
> > another likely culprit (unless https://src.chromium.org/viewvc/blink?view=rev&revision=187932)
> >
> > The failures started on:
> > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113
> >
> > Chrome revision range:
> > https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d7320f2ebdf610decdc..3a5e72899629e0c8d254109707e747742686fbca
> >
> > Blink revision range:
> > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=187921%3A187936&mode=html
> >
> > Original issue's description:
> > > Enable display list 2D canvas by default
> > >
> > > With this change, display list 2D canvas will become enabled by
> > > default in Chrome. Content shell with --dump-render-tree will
> > > continue to have display lists disabled by default.
> > > Currently, having display lists enabled in blink means
> > > that display lists will be used whenever 2d canvases would
> > > not be GPU-accelerated.
> > >
> > > BUG=386601
> > >
> > > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae
> > > Cr-Commit-Position: refs/heads/master@{#309453}
> >
> > TBR=avi@chromium.org,junov@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=386601
> >
> > Committed: https://crrev.com/b314d341e5c60c03aa118e96318d54a84f00b053
> > Cr-Commit-Position: refs/heads/master@{#310252}
>
> TBR=avi@chromium.org,junov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=386601
>
> Committed: https://crrev.com/b95bb640426d6e875421462efd6715f4a10488b1
> Cr-Commit-Position: refs/heads/master@{#310265}
TBR=avi@chromium.org,junov@chromium.org,falken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=386601
Committed: https://crrev.com/332a67f090516a637f242c60a0c8f784c4192b18
Cr-Commit-Position: refs/heads/master@{#310501}
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|