Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: Source/core/rendering/RenderVTTCue.cpp

Issue 806483002: Oilpan: trace RenderVTTCue's cue back reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderVTTCue.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org) 2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org)
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 19 matching lines...) Expand all
30 #include "core/rendering/RenderView.h" 30 #include "core/rendering/RenderView.h"
31 31
32 namespace blink { 32 namespace blink {
33 33
34 RenderVTTCue::RenderVTTCue(VTTCueBox* element) 34 RenderVTTCue::RenderVTTCue(VTTCueBox* element)
35 : RenderBlockFlow(element) 35 : RenderBlockFlow(element)
36 , m_cue(element->getCue()) 36 , m_cue(element->getCue())
37 { 37 {
38 } 38 }
39 39
40 void RenderVTTCue::trace(Visitor* visitor)
41 {
42 visitor->trace(m_cue);
43 RenderBlockFlow::trace(visitor);
44 }
45
40 void RenderVTTCue::layout() 46 void RenderVTTCue::layout()
41 { 47 {
42 RenderBlockFlow::layout(); 48 RenderBlockFlow::layout();
43 49
44 // If WebVTT Regions are used, the regular WebVTT layout algorithm is no 50 // If WebVTT Regions are used, the regular WebVTT layout algorithm is no
45 // longer necessary, since cues having the region parameter set do not have 51 // longer necessary, since cues having the region parameter set do not have
46 // any positioning parameters. Also, in this case, the regions themselves 52 // any positioning parameters. Also, in this case, the regions themselves
47 // have positioning information. 53 // have positioning information.
48 if (!m_cue->regionId().isEmpty()) 54 if (!m_cue->regionId().isEmpty())
49 return; 55 return;
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 } 266 }
261 } 267 }
262 268
263 void RenderVTTCue::repositionCueSnapToLinesNotSet() 269 void RenderVTTCue::repositionCueSnapToLinesNotSet()
264 { 270 {
265 // FIXME: Implement overlapping detection when snap-to-lines is not set. htt p://wkb.ug/84296 271 // FIXME: Implement overlapping detection when snap-to-lines is not set. htt p://wkb.ug/84296
266 } 272 }
267 273
268 } // namespace blink 274 } // namespace blink
269 275
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderVTTCue.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698