Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: media/mojo/services/BUILD.gn

Issue 806443002: Enable PipelineIntegrationTests in mojo! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup. All pass! Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index c9e7a262c99e572b324a1709d30e0931185f9583..5c77973013a316c894521365e2f9ca32bb0822b8 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -109,28 +109,16 @@ if (!is_component_build) {
]
}
- # Not a 'test' because this is loaded via mojo_shell as an app.
- # To run the test:
- # out/Debug/mojo_shell mojo:media_test
- # You can get "mojo_shell" using mojo/public/tools/download_shell_binary.py
+ # Note, this 'test' must be loaded via mojo_shell as an app:
+ #
+ # out/Debug/mojo_shell mojo://media_test
xhwang 2014/12/17 05:25:03 OOC, is mojo:media_test not working, or is mojo://
DaleCurtis 2014/12/17 21:40:49 It works. I thought a thread encouraged the :// be
xhwang 2014/12/17 21:53:38 jamesr: Do you know what's the recommended style n
+ #
+ # To get "mojo_shell" you must specify "use_prebuilt_mojo_shell=true" in GN.
mojo_native_application("media_test") {
testonly = true
- sources = [
- "media_renderer_apptest.cc",
- ]
deps = [
- ":media",
- ":renderer_proxy",
- "//base",
- "//media",
- "//media/mojo/interfaces",
- "//media:shared_memory_support",
- "//mojo/application",
- "//mojo/application:test_support",
- "//mojo/common",
- "//mojo/environment:chromium",
- "//mojo/public/c/system:for_shared_library",
+ "//media/test:mojo_pipeline_integration_tests",
]
}
}
« no previous file with comments | « no previous file | media/mojo/services/media_renderer_apptest.cc » ('j') | media/test/pipeline_integration_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698