Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 806433002: Support horizontal/vertical only images in NineImagePainter (Closed)

Created:
6 years ago by oshima
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support horizontal/vertical only images in NineImagePainter. This will be used in https://codereview.chromium.org/798163003/ BUG=432500 Committed: https://crrev.com/e98d8d68c1cde7ae05386befdd797360c7900b76 Cr-Commit-Position: refs/heads/master@{#308440}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M ui/base/nine_image_painter_factory.h View 3 1 chunk +11 lines, -0 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 1 3 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
oshima
6 years ago (2014-12-13 02:14:50 UTC) #2
sadrul
LGTM https://codereview.chromium.org/806433002/diff/1/ui/gfx/nine_image_painter.cc File ui/gfx/nine_image_painter.cc (right): https://codereview.chromium.org/806433002/diff/1/ui/gfx/nine_image_painter.cc#newcode190 ui/gfx/nine_image_painter.cc:190: } It would be nice if we didn't ...
6 years ago (2014-12-15 17:21:19 UTC) #3
oshima
Uploaded new patch. PTAL
6 years ago (2014-12-15 19:16:28 UTC) #8
oshima
https://codereview.chromium.org/806433002/diff/120001/ui/base/nine_image_painter_factory.h File ui/base/nine_image_painter_factory.h (right): https://codereview.chromium.org/806433002/diff/120001/ui/base/nine_image_painter_factory.h#newcode44 ui/base/nine_image_painter_factory.h:44: const int kImageGridNum = 9; I added this to ...
6 years ago (2014-12-15 19:25:25 UTC) #9
oshima
https://codereview.chromium.org/806433002/diff/120001/ui/base/nine_image_painter_factory.h File ui/base/nine_image_painter_factory.h (right): https://codereview.chromium.org/806433002/diff/120001/ui/base/nine_image_painter_factory.h#newcode44 ui/base/nine_image_painter_factory.h:44: const int kImageGridNum = 9; On 2014/12/15 19:25:25, oshima ...
6 years ago (2014-12-15 21:26:38 UTC) #10
sadrul
LGTM!
6 years ago (2014-12-15 21:29:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806433002/140001
6 years ago (2014-12-15 21:31:36 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:140001)
6 years ago (2014-12-15 22:22:03 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-15 22:23:14 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e98d8d68c1cde7ae05386befdd797360c7900b76
Cr-Commit-Position: refs/heads/master@{#308440}

Powered by Google App Engine
This is Rietveld 408576698