Fix input injector on Linux to release all keys before injecting text event.

remoting/host/input_injector_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/input_injector.h"
 
 #include <X11/extensions/XInput.h>
 #include <X11/extensions/XTest.h>
 #include <X11/Xlib.h>
 #include <X11/XKBlib.h>
@@ skipping 309 matching lines @@
   XFlush(display_);
 }
 
 void InputInjectorX11::Core::InjectTextEvent(const TextEvent& event) {
   if (!task_runner_->BelongsToCurrentThread()) {
     task_runner_->PostTask(FROM_HERE,
                            base::Bind(&Core::InjectTextEvent, this, event));
     return;
   }
 
+  // Release all keys before injecting text event. This is necessary to avoid
+  // any interference with the currently pressed keys. E.g. if Shift is pressed
+  // when TextEvent is received.
+  for (std::set<int>::iterator it = pressed_keys_.begin();

[Lambros, 2014/12/22 23:05:11]

nit: Prefer const_iterator
Could use C++11 here: for (int key : pressed_keys_) ?

[Sergey Ulanov, 2014/12/23 00:13:28]

Done.

+       it != pressed_keys_.end(); ++it) {
+    XTestFakeKeyEvent(display_, *it, False, CurrentTime);
+  }
+  pressed_keys_.clear();
+
   const std::string text = event.text();
   for (int32 index = 0; index < static_cast<int32>(text.size()); ++index) {
     uint32_t code_point;
     if (!base::ReadUnicodeCharacter(
             text.c_str(), text.size(), &index, &code_point)) {
       continue;
     }
 
     uint32_t keycode;
     uint32_t modifiers;
@@ skipping 278 matching lines @@
     scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) {
   scoped_ptr<InputInjectorX11> injector(
       new InputInjectorX11(main_task_runner));
   if (!injector->Init())
     return nullptr;
   return injector.Pass();
 }
 
 }  // namespace remoting