Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 806223002: Remove unused/unneeded code from core/editing. (Closed)

Created:
6 years ago by bzsolt
Modified:
5 years, 11 months ago
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused/unneeded code from core/editing. Remove few unused method and CaretBase::m_caretRectNeedsUpdate member, because it is not checked, but adjusted. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M Source/core/editing/Caret.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/Caret.cpp View 4 chunks +1 line, -18 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/TextCheckingHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
bzsolt
6 years ago (2014-12-16 17:27:59 UTC) #2
Yuta Kitamura
lgtm, adding yosin to be sure
5 years, 11 months ago (2015-01-08 06:52:06 UTC) #4
yosin_UTC9
lgtm. Thanks for cleanup! +yoichio who made unused variables and functions in |Caret| class for ...
5 years, 11 months ago (2015-01-14 01:39:24 UTC) #6
yoichio
lgtm
5 years, 11 months ago (2015-01-14 02:11:43 UTC) #7
bzsolt
Thanks for the reviews!
5 years, 11 months ago (2015-01-14 10:14:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806223002/1
5 years, 11 months ago (2015-01-14 10:15:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink ()
5 years, 11 months ago (2015-01-14 12:23:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806223002/1
5 years, 11 months ago (2015-01-21 21:50:43 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 23:03:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188777

Powered by Google App Engine
This is Rietveld 408576698