Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 806213002: Do not inline complex constructor. (Closed)

Created:
6 years ago by qsr
Modified:
6 years ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Nor destructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M shell/android/android_handler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/android_handler.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
6 years ago (2014-12-16 15:50:27 UTC) #1
ppi
lgtm
6 years ago (2014-12-16 15:54:26 UTC) #2
qsr
6 years ago (2014-12-16 15:55:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6939a5acd0d0df0018d51777c6c3690310a822af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698