Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: Source/core/frame/Frame.h

Issue 806183005: Remove FrameLoader's checkLoadComplete and checkLoadCompleteForThisFrame (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 WebLayer* remotePlatformLayer() const { return m_remotePlatformLayer; } 95 WebLayer* remotePlatformLayer() const { return m_remotePlatformLayer; }
96 96
97 Settings* settings() const; // can be null 97 Settings* settings() const; // can be null
98 98
99 // FIXME: This method identifies a LocalFrame that is acting as a RemoteFram e. 99 // FIXME: This method identifies a LocalFrame that is acting as a RemoteFram e.
100 // It is necessary only until we can instantiate a RemoteFrame, at which poi nt 100 // It is necessary only until we can instantiate a RemoteFrame, at which poi nt
101 // it can be removed and its callers can be converted to use the isRemoteFra me() 101 // it can be removed and its callers can be converted to use the isRemoteFra me()
102 // method. 102 // method.
103 bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; } 103 bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; }
104 104
105 virtual bool checkLoadComplete() = 0;
106
107 // isLoading() is true when the embedder should think a load is in progress. 105 // isLoading() is true when the embedder should think a load is in progress.
108 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading() 106 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading()
109 // callback, but not the matching didStopLoading(). Inside blink, you probab ly 107 // callback, but not the matching didStopLoading(). Inside blink, you probab ly
110 // want Document::loadEventFinished() instead. 108 // want Document::loadEventFinished() instead.
111 void setIsLoading(bool isLoading) { m_isLoading = isLoading; } 109 void setIsLoading(bool isLoading) { m_isLoading = isLoading; }
112 bool isLoading() const { return m_isLoading; } 110 bool isLoading() const { return m_isLoading; }
113 111
114 protected: 112 protected:
115 Frame(FrameClient*, FrameHost*, FrameOwner*); 113 Frame(FrameClient*, FrameHost*, FrameOwner*);
116 114
(...skipping 23 matching lines...) Expand all
140 { 138 {
141 return m_treeNode; 139 return m_treeNode;
142 } 140 }
143 141
144 // Allow equality comparisons of Frames by reference or pointer, interchangeably . 142 // Allow equality comparisons of Frames by reference or pointer, interchangeably .
145 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame) 143 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame)
146 144
147 } // namespace blink 145 } // namespace blink
148 146
149 #endif // Frame_h 147 #endif // Frame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698