Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: sky/tests/framework/templates.sky

Issue 806133003: Fix detached callback and add isAttached to SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: don't change shadow root test yet. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tests/framework/templates.sky
diff --git a/sky/tests/framework/templates.sky b/sky/tests/framework/templates.sky
index 30e119fc41245eef95441152d2515a3c1a8106b2..2ad0674c663fb05b4b8bf660ab70bad66396a337 100644
--- a/sky/tests/framework/templates.sky
+++ b/sky/tests/framework/templates.sky
@@ -17,6 +17,14 @@ describe("SkyElement templates", function() {
element.remove();
});
+ it("should update isAttached when inserting", function() {
+ assert.isFalse(element.isAttached);
+ sandbox.appendChild(element);
+ assert.isTrue(element.isAttached);
+ element.remove();
+ assert.isFalse(element.isAttached);
+ });
+
it("should stamp when the element is inserted", function() {
assert.isNull(element.shadowRoot);
sandbox.appendChild(element);

Powered by Google App Engine
This is Rietveld 408576698