Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: sky/tests/framework/templates.sky

Issue 806133003: Fix detached callback and add isAttached to SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Don't hide state for now. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/framework/sky-element/sky-element.sky ('k') | sky/tests/framework/templates-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <sky> 1 <sky>
2 <import src="/sky/tests//resources/chai.sky" /> 2 <import src="/sky/tests//resources/chai.sky" />
3 <import src="/sky/tests/resources/mocha.sky" /> 3 <import src="/sky/tests/resources/mocha.sky" />
4 <import src="/sky/tests/resources/test-element.sky" as="TestElement" /> 4 <import src="/sky/tests/resources/test-element.sky" as="TestElement" />
5 5
6 <div id="sandbox"></div> 6 <div id="sandbox"></div>
7 7
8 <script> 8 <script>
9 describe("SkyElement templates", function() { 9 describe("SkyElement templates", function() {
10 var element; 10 var element;
11 var sandbox = document.getElementById("sandbox"); 11 var sandbox = document.getElementById("sandbox");
12 12
13 beforeEach(function() { 13 beforeEach(function() {
14 element = new TestElement(); 14 element = new TestElement();
15 }); 15 });
16 afterEach(function() { 16 afterEach(function() {
17 element.remove(); 17 element.remove();
18 }); 18 });
19 19
20 it("should stamp when the element is inserted", function() { 20 it("should stamp when the element is inserted", function() {
21 assert.isNull(element.shadowRoot); 21 assert.isNull(element.shadowRoot);
22 sandbox.appendChild(element); 22 sandbox.appendChild(element);
23 assert.instanceOf(element.shadowRoot, ShadowRoot); 23 assert.instanceOf(element.shadowRoot, ShadowRoot);
24 assert.ok(element.shadowRoot.getElementById("inside")); 24 assert.ok(element.shadowRoot.getElementById("inside"));
25 }); 25 });
26 26
27 it("should update isAttached when inserting", function() {
28 assert.isFalse(element.isAttached);
29 sandbox.appendChild(element);
30 assert.isTrue(element.isAttached);
31 element.remove();
32 assert.isFalse(element.isAttached);
33 });
34
27 it("should connect data binding", function(done) { 35 it("should connect data binding", function(done) {
28 sandbox.appendChild(element); 36 sandbox.appendChild(element);
29 var inside = element.shadowRoot.getElementById("inside"); 37 var inside = element.shadowRoot.getElementById("inside");
30 Promise.resolve().then(function() { 38 Promise.resolve().then(function() {
31 assert.equal(inside.textContent, 10); 39 assert.equal(inside.textContent, 10);
32 assert.equal(inside.attr, 10); 40 assert.equal(inside.attr, 10);
33 element.value = 20; 41 element.value = 20;
34 }).then(function() { 42 }).then(function() {
35 assert.equal(inside.textContent, 20); 43 assert.equal(inside.textContent, 20);
36 assert.equal(inside.attr, 20); 44 assert.equal(inside.attr, 20);
(...skipping 17 matching lines...) Expand all
54 assert.equal(element.shadowRootReadyCount, 0); 62 assert.equal(element.shadowRootReadyCount, 0);
55 sandbox.appendChild(element); 63 sandbox.appendChild(element);
56 assert.equal(element.shadowRootReadyCount, 1); 64 assert.equal(element.shadowRootReadyCount, 1);
57 element.remove(); 65 element.remove();
58 sandbox.appendChild(element); 66 sandbox.appendChild(element);
59 assert.equal(element.shadowRootReadyCount, 1); 67 assert.equal(element.shadowRootReadyCount, 1);
60 }); 68 });
61 }); 69 });
62 </script> 70 </script>
63 </sky> 71 </sky>
OLDNEW
« no previous file with comments | « sky/framework/sky-element/sky-element.sky ('k') | sky/tests/framework/templates-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698