Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 806123002: Revert of NaCl: Update revision in DEPS, r14201 -> r14213 (Closed)

Created:
6 years ago by samuong1
Modified:
6 years ago
CC:
chromium-reviews, bradn, Derek Schuff, JF, jvoung - send to chromium..., mazda, native-client-reviews_googlegroups.com, shyamsundarr, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r14201 -> r14213 (patchset #1 id:1 of https://codereview.chromium.org/804143002/) Reason for revert: this cl is causing a perf regression that causes the sizes step to fail: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/75029 PERF_REGRESS: nacl_helper-text/text (0.94%), nacl_helper/nacl_helper (0.41%), nacl_helper-text/text (0.94%), nacl_helper/nacl_helper (0.41%) Original issue's description: > NaCl: Update revision in DEPS, r14201 -> r14213 > > This pulls in the following Native Client changes: > > r14202: (mazda) Non-SFI mode: Make nacl_helper_nonsfi build depend on libnacl_sys_private.a > r14203: (mazda) Fix stack alignment of child threads on ARM. > r14204: (jvoung) Switch -split-module-sched back to dynamic for the sandboxed case. > r14205: (jfb) Mark performance tests as broken when running on VMs > r14206: (shyamsundarr) enable remaining disabled avx1 ops. > r14208: (dschuff) toolchain_build: Use 'build_noncanonical' target type for target libraries > r14209: (dschuff) Revert "toolchain_build: Use 'build_noncanonical' target type for target libraries" > r14210: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r14211: (bradnelson) Turn off graphing for pnacl-buildonly-spec. > r14212: (teravest) Always emit original sources from scan_sources. > r14213: (dschuff) toolchain_build: Use 'build_noncanonical' target type for target libraries > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk > > Committed: https://crrev.com/822e1f35f882dc414a984a46b77e92ef4d93f05c > Cr-Commit-Position: refs/heads/master@{#308485} TBR=dschuff@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/ee2dd54e61d772d6740509f210b9787db0c86773 Cr-Commit-Position: refs/heads/master@{#308535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong1
Created Revert of NaCl: Update revision in DEPS, r14201 -> r14213
6 years ago (2014-12-16 05:44:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806123002/1
6 years ago (2014-12-16 05:45:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 05:45:58 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-16 05:46:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee2dd54e61d772d6740509f210b9787db0c86773
Cr-Commit-Position: refs/heads/master@{#308535}

Powered by Google App Engine
This is Rietveld 408576698