Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 806103003: cps-ir: Add support for intercepted calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Bailout on special selectors. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
index 1dc36271993f9d524509042924fcb36f4bda2a09..41eeb38643b137471f56627773e1a4b1f8939151 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
@@ -6,6 +6,9 @@ import '../../cps_ir/cps_ir_nodes.dart';
import '../../cps_ir/optimizers.dart';
import '../../constants/expressions.dart';
import '../../constants/values.dart';
+import '../../elements/elements.dart' show ClassElement;
+import '../../js_backend/codegen/glue.dart';
+import '../../dart2jslib.dart' show Selector;
/// Rewrites the initial CPS IR to make Dart semantics explicit and inserts
/// special nodes that respect JavaScript behavior.
@@ -13,7 +16,9 @@ import '../../constants/values.dart';
/// Performs the following rewrites:
/// - rewrite [IsTrue] in a [Branch] to do boolean conversion.
class UnsugarVisitor extends RecursiveVisitor {
- const UnsugarVisitor();
+ Glue _glue;
+
+ UnsugarVisitor(this._glue);
void rewrite(FunctionDefinition function) {
// Set all parent pointers.
@@ -33,6 +38,37 @@ class UnsugarVisitor extends RecursiveVisitor {
new TrueConstantValue()));
}
+ processInvokeMethod(InvokeMethod node) {
+ Selector selector = node.selector;
+ if (!_glue.isInterceptedSelector(selector)) return;
+
+ if (!selector.isCall && !selector.isOperator) {
+ // TODO(karlklose): handle special selectors.
+ return;
+ }
+
+ Set<ClassElement> interceptedClasses =
+ _glue.getInterceptedClassesOn(selector);
+ _glue.registerSpecializedGetInterceptor(interceptedClasses);
+ InteriorNode parent = node.parent;
+ Primitive receiver = node.receiver.definition;
+ Primitive intercepted = new Interceptor(receiver, interceptedClasses);
+ List<Reference<Primitive>> arguments =
+ new List<Reference<Primitive>>.generate(node.arguments.length + 1,
+ (int index) {
+ return index == 0 ? new Reference<Primitive>(receiver)
+ : node.arguments[index - 1];
+ });
+ LetPrim newNode = new LetPrim(intercepted,
+ new InvokeMethod.internal(new Reference<Primitive>(intercepted),
+ selector,
+ new Reference<Continuation>(node.continuation.definition),
+ arguments));
+ node.continuation.unlink();
+ node.receiver.unlink();
+ parent.body = newNode;
+ }
+
processBranch(Branch node) {
// TODO(karlklose): implement the checked mode part of boolean conversion.
InteriorNode parent = node.parent;

Powered by Google App Engine
This is Rietveld 408576698