Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 806103003: cps-ir: Add support for intercepted calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Bailout on special selectors. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index bdcb7dc015afc541453cf2550d2ea3ef9ae81ebf..bbb24b16d3d00fef9dd50856470efe8abb0ee2aa 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -170,7 +170,6 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
Element target,
List<js.Expression> arguments) {
registry.registerStaticInvocation(target.declaration);
-
js.Expression elementAccess = glue.staticFunctionAccess(target);
List<js.Expression> compiledArguments =
selector.makeArgumentsList(target.implementation,
@@ -197,16 +196,10 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
@override
js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
- // TODO(sigurdm): Handle intercepted invocations.
- if (glue.isIntercepted(node.selector)) giveup(node);
- js.Expression receiver = visitExpression(node.receiver);
-
- List<js.Expression> arguments = visitArguments(node.arguments);
-
- String methodName = glue.invocationName(node.selector);
registerMethodInvoke(node);
-
- return js.propertyCall(receiver, methodName, arguments);
+ return js.propertyCall(visitExpression(node.receiver),
+ glue.invocationName(node.selector),
+ visitArguments(node.arguments));
}
@override

Powered by Google App Engine
This is Rietveld 408576698