Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 806063004: Expose ARIA role status on MAC (Closed)

Created:
5 years, 12 months ago by shreeramk
Modified:
5 years, 11 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose ARIA role status on MAC On mac Aria role status should be exposed as follow AXRole: AXGroup AXSubrole: AXApplicationStatus AXRoleDescription: 'status' This CL depends on blink side cl https://codereview.chromium.org/829773002/ BUG=445354 Committed: https://crrev.com/7630ad8bc3bd2ae064b4deae81f9290054c75358 Cr-Commit-Position: refs/heads/master@{#310246}

Patch Set 1 #

Patch Set 2 : Support AXRoleDescription & AXSubrole on mac #

Patch Set 3 : adding expectations for mac and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M content/app/strings/content_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-status.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-status-expected-android.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-status-expected-mac.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-status-expected-win.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
shreeramk
Please review. Thanks!
5 years, 11 months ago (2015-01-05 09:32:06 UTC) #2
dmazzoni
lgtm Needs -expected-*.txt files for mac & android too
5 years, 11 months ago (2015-01-05 23:56:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806063004/40001
5 years, 11 months ago (2015-01-07 05:53:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/33591)
5 years, 11 months ago (2015-01-07 06:00:22 UTC) #7
shreeramk
avi@chromium.org: Please review changes in content_strings.grd. Thanks!
5 years, 11 months ago (2015-01-07 06:02:55 UTC) #9
Avi (use Gerrit)
lgtm
5 years, 11 months ago (2015-01-07 06:46:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806063004/40001
5 years, 11 months ago (2015-01-07 07:11:39 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-07 07:15:33 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 07:16:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7630ad8bc3bd2ae064b4deae81f9290054c75358
Cr-Commit-Position: refs/heads/master@{#310246}

Powered by Google App Engine
This is Rietveld 408576698