Issue 806043002: Use existing unicode.sky instead of re-inventing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 806043002: Use existing unicode.sky instead of re-inventing (Closed)

Created:
6 years ago by eseidel

Modified:
6 years ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Use existing unicode.sky instead of re-inventing I somehow missed this function the first time. This is already tested by tests/framework/xmlhttprequest/unicode-post.sky R=esprehn@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/d5ff26b6564f2069af0a2a9e5b7553190d38cec5

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -12 lines)			Patch
	M	sky/framework/xmlhttprequest.sky	View		2 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

eseidel

6 years ago (2014-12-17 20:11:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d5ff26b6564f2069af0a2a9e5b7553190d38cec5 (presubmit successful).