Issue 80603004: Handle both OSX and iOS Simulator runtimes in the ASan postbuild script.

Issue 80603004: Handle both OSX and iOS Simulator runtimes in the ASan postbuild script. (Closed)

Created:
7 years, 1 month ago by Alexander Potapenko

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Handle both OSX and iOS Simulator runtimes in the ASan postbuild script. Also fixed a TODO: now the script bails out if a non-ASan executable is passed to it. BUG=228243 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236738

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
	M	build/mac/copy_asan_runtime_dylib.sh	View	1	1 chunk	+21 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_dylib.sh File build/mac/copy_asan_runtime_dylib.sh (left): https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_dylib.sh#oldcode28 build/mac/copy_asan_runtime_dylib.sh:28: # runtime in ASan. Mention that you fixed ...

7 years, 1 month ago (2013-11-22 01:48:19 UTC) #2

Alexander Potapenko

Committed patchset #2 manually as r236738 (presubmit successful).

7 years, 1 month ago (2013-11-22 09:25:22 UTC) #3

Alexander Potapenko

7 years, 1 month ago (2013-11-22 09:26:13 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_d...
File build/mac/copy_asan_runtime_dylib.sh (left):

https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_d...
build/mac/copy_asan_runtime_dylib.sh:28: # runtime in ASan.
On 2013/11/22 01:48:19, Nico (in Tokyo until Nov 25) wrote:
> Mention that you fixed this TODO in the cl description too, please.

Done.

https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_d...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_d...
build/mac/copy_asan_runtime_dylib.sh:19: fi
On 2013/11/22 01:48:19, Nico (in Tokyo until Nov 25) wrote:
> This script is called for non-binaries due to that gyp bug which doesn't allow
a
> _type check in gyp, right? Explain that here, and maybe add a note that this
can
> be removed if that gyp bug (maybe 380?) gets fixed.

This is because the script is being also called for every _mac_bundle (see
build/common.gypi) including those with '.bundle' extension, which do not
contain executable files.

Recalling a discussion with rsleevi last January I'm now more sceptic about
fixing gyp 380, but will look again.

https://codereview.chromium.org/80603004/diff/1/build/mac/copy_asan_runtime_d...
build/mac/copy_asan_runtime_dylib.sh:30: if [[ "${BUILTIN_DYLIB_PATH}" ==
*asan_osx_dynamic* ]]; then
On 2013/11/22 01:48:19, Nico (in Tokyo until Nov 25) wrote:
> elif

Done.

Expand Messages | Collapse Messages