Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 8060015: Update boost to 1.47.0 and, with glibc, build more boost libraries. (Closed)

Created:
9 years, 2 months ago by Evgeniy Stepanov
Modified:
9 years, 2 months ago
Reviewers:
khim, bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update boost to 1.47.0 and, with glibc, build more boost libraries. Committed: http://code.google.com/p/naclports/source/detail?r=448

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2049 lines) Patch
M Makefile View 3 chunks +3 lines, -2 lines 0 comments Download
D libraries/boost_1_43_0/boost_1_43_0.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D libraries/boost_1_43_0/nacl-boost_1_43_0.patch View 1 1 chunk +0 lines, -1992 lines 0 comments Download
D libraries/boost_1_43_0/nacl-boost_1_43_0.sh View 1 chunk +0 lines, -54 lines 0 comments Download
A libraries/boost_1_47_0/boost_1_47_0.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A libraries/boost_1_47_0/nacl-boost_1_47_0.sh View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evgeniy Stepanov
9 years, 2 months ago (2011-09-27 16:59:23 UTC) #1
khim
http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boost_1_47_0.sh File libraries/boost_1_47_0/nacl-boost_1_47_0.sh (right): http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boost_1_47_0.sh#newcode31 libraries/boost_1_47_0/nacl-boost_1_47_0.sh:31: link=static \ Hmm... This is kind of strange? Why ...
9 years, 2 months ago (2011-09-27 18:17:54 UTC) #2
bradn
Other than victor's question about static, LGTM
9 years, 2 months ago (2011-09-27 18:20:56 UTC) #3
Evgeniy Stepanov
http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boost_1_47_0.sh File libraries/boost_1_47_0/nacl-boost_1_47_0.sh (right): http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boost_1_47_0.sh#newcode31 libraries/boost_1_47_0/nacl-boost_1_47_0.sh:31: link=static \ On 2011/09/27 18:17:54, khim wrote: > Hmm... ...
9 years, 2 months ago (2011-09-27 18:38:28 UTC) #4
Evgeniy Stepanov
9 years, 2 months ago (2011-09-27 18:40:56 UTC) #5
bradn
k, lgtm
9 years, 2 months ago (2011-09-27 18:43:22 UTC) #6
Evgeniy Stepanov
9 years, 2 months ago (2011-09-28 00:38:06 UTC) #7
http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boo...
File libraries/boost_1_47_0/nacl-boost_1_47_0.sh (right):

http://codereview.chromium.org/8060015/diff/1/libraries/boost_1_47_0/nacl-boo...
libraries/boost_1_47_0/nacl-boost_1_47_0.sh:31: link=static \
On 2011/09/27 18:38:28, Evgeniy Stepanov wrote:
> On 2011/09/27 18:17:54, khim wrote:
> > Hmm... This is kind of strange? Why are we installing only static boost for
> > GLibC?
> 
> That's a historic artifact. I think everything I uploaded today and yesterday
is
> build only as static libraries.
> 
> I'll mass-convert them in a separate change.

I'd like to point out that DefaultConfigureStep() includes --disable-shared
flag. Also, as far as I know, libtools do not recognize that our linker is
capable of creating dynamic libraries and refuse to build one. Is there a recipe
how to fight this?

Powered by Google App Engine
This is Rietveld 408576698