Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 805993002: Add more data to conversion failure messages in gin (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more data to conversion failure messages in gin This CL also makes it more clear in gin when type coercion fails what argument (0-indexed) failed to convert and what js type was seen in the process. I started down the path of logging the c++ destination type as well, but found I couldn't with our current RTTI-less build. This was already reviewed in: https://codereview.chromium.org/798163002/ before I realized that gin was maintained in chromium. TBR=abarth@chromium.org BUG= Committed: https://crrev.com/2584930fa1638c37c4cd4fa796c4103561f4a503 Cr-Commit-Position: refs/heads/master@{#308435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M gin/arguments.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M gin/function_template.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
abarth reviewed in mojo, but happy to have additional reviews if folks feel so inclined.
6 years ago (2014-12-15 20:42:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805993002/1
6 years ago (2014-12-15 20:43:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 22:06:51 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-15 22:07:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2584930fa1638c37c4cd4fa796c4103561f4a503
Cr-Commit-Position: refs/heads/master@{#308435}

Powered by Google App Engine
This is Rietveld 408576698