Remove hardware check that enables always-on hotwording.

Remove hardware check that enables always-on hotwording.

BUG=448859
Committed: https://crrev.com/e014345eab81e39c48956f9dae0cc0c66e170f08
Cr-Commit-Position: refs/heads/master@{#311797}

[Anand Mistry (off Chromium), 2015-01-14 23:28:32]

amistry@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Anand Mistry (off Chromium), 2015-01-14 23:28:33]

Change for merging into M41.

[Matt Giuca, 2015-01-15 01:51:22]

https://codereview.chromium.org/805943005/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/805943005/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:49: bool
HotwordServiceFactory::IsHotwordHardwareAvailable() {
I don't like the idea of removing this code; I understand that we'll want it
back at some point in the future, just that we want it disabled for now.

Can we just change this to
#if false
with a comment explaining why it is disabled?

[Anand Mistry (off Chromium), 2015-01-15 02:21:01]

https://codereview.chromium.org/805943005/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/805943005/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:49: bool
HotwordServiceFactory::IsHotwordHardwareAvailable() {
On 2015/01/15 01:51:21, Matt Giuca wrote:
> I don't like the idea of removing this code; I understand that we'll want it
> back at some point in the future, just that we want it disabled for now.
> 
> Can we just change this to
> #if false
> with a comment explaining why it is disabled?

Done.

[Matt Giuca, 2015-01-15 02:56:43]

lgtm

So are you planning to immediately revert this CL, and just merge this one?

https://codereview.chromium.org/805943005/diff/20001/chrome/browser/search/ho...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/805943005/diff/20001/chrome/browser/search/ho...
chrome/browser/search/hotword_service_factory.cc:53: #if defined(OS_CHROMEOS)
I think you should delete this inner if.

Your choice.

[Anand Mistry (off Chromium), 2015-01-15 03:17:26]

On 2015/01/15 02:56:43, Matt Giuca wrote:
> lgtm
> 
> So are you planning to immediately revert this CL, and just merge this one?

That's pretty much the plan.

> 
>
https://codereview.chromium.org/805943005/diff/20001/chrome/browser/search/ho...
> File chrome/browser/search/hotword_service_factory.cc (right):
> 
>
https://codereview.chromium.org/805943005/diff/20001/chrome/browser/search/ho...
> chrome/browser/search/hotword_service_factory.cc:53: #if defined(OS_CHROMEOS)
> I think you should delete this inner if.
> 
> Your choice.

Nah, considering I'm just going to undo this soon.

[Anand Mistry (off Chromium), 2015-01-15 03:18:32]

amistry@chromium.org changed reviewers:
+ thestig@chromium.org

[Anand Mistry (off Chromium), 2015-01-15 03:18:33]

thestig@chromium.org: For OWNERS approval.

[Lei Zhang, 2015-01-15 03:38:51]

lgtm, please revert soon

[Anand Mistry (off Chromium), 2015-01-15 03:49:48]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-01-15 03:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805943005/20001

[commit-bot: I haz the power, 2015-01-15 04:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 04:52:50]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Anand Mistry (off Chromium), 2015-01-15 22:58:29]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-01-15 23:00:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805943005/20001

[commit-bot: I haz the power, 2015-01-15 23:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 23:02:26]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Anand Mistry (off Chromium), 2015-01-16 00:50:18]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-01-16 00:51:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805943005/20001

[commit-bot: I haz the power, 2015-01-16 00:53:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-16 00:55:03]

Patchset 2 (id:??) landed as
https://crrev.com/e014345eab81e39c48956f9dae0cc0c66e170f08
Cr-Commit-Position: refs/heads/master@{#311797}