Remove TypeConverter and Module from minimal subzero build.

Remove TypeConverter and Module from minimal subzero build.

Removes the need to model LLVM types from the minimal subzero build.
It isn't removed from the nonminimal build because IceConverter still needs
to be able to convert LLVM types to corresponding Ice types.

Note that this CL reduces the size of Release+Min/llvm2ice (after
strip) to about 638K bytes.

BUG=None
R=jvoung@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4019f0843ff2efdde366402f692f0853a206bac8

[Karl, 2014-12-15 18:57:25]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[jvoung (off chromium), 2014-12-15 19:40:41]

Cool!

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:20: #include "llvm/IR/LLVMContext.h"
Can the LLVMContext header be removed too?

[jvoung (off chromium), 2014-12-15 19:47:02]

https://codereview.chromium.org/805943002/diff/1/src/IceTypeConverter.h
File src/IceTypeConverter.h (right):

https://codereview.chromium.org/805943002/diff/1/src/IceTypeConverter.h#newco...
src/IceTypeConverter.h:40: // Note: We use "at" here in case Ty wasn't
registered.
You might be able to remove this, since I only see it used by the
PNaClTranslator?

[Jim Stichnoth, 2014-12-15 20:17:08]

Awesome!  With this patch, the only big LLVM symbols that stand out are
llvm::cl, and some stuff involving parsing llvm-triple strings.  Very very nice.

Otherwise LGTM.

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:171: TopLevelParser(Ice::Translator &Translator, const
std::string &InputName,
Can you remove the InputName arg, or something?  It's no longer being used and
produces a warning.

[Karl, 2014-12-15 20:27:54]

https://codereview.chromium.org/805943002/diff/1/src/IceTypeConverter.h
File src/IceTypeConverter.h (right):

https://codereview.chromium.org/805943002/diff/1/src/IceTypeConverter.h#newco...
src/IceTypeConverter.h:40: // Note: We use "at" here in case Ty wasn't
registered.
On 2014/12/15 19:47:02, jvoung wrote:
> You might be able to remove this, since I only see it used by the
> PNaClTranslator?

Removed.

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:20: #include "llvm/IR/LLVMContext.h"
On 2014/12/15 19:40:41, jvoung wrote:
> Can the LLVMContext header be removed too?

Removed.

https://codereview.chromium.org/805943002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:171: TopLevelParser(Ice::Translator &Translator, const
std::string &InputName,
On 2014/12/15 20:17:08, stichnot wrote:
> Can you remove the InputName arg, or something?  It's no longer being used and
> produces a warning.

Removed.

[jvoung (off chromium), 2014-12-15 21:05:33]

otherwise LGTM too

https://codereview.chromium.org/805943002/diff/20001/src/IceTypeConverter.h
File src/IceTypeConverter.h (left):

https://codereview.chromium.org/805943002/diff/20001/src/IceTypeConverter.h#o...
src/IceTypeConverter.h:41: return LLVMTypes.at(Ty);
I think this means that LLVMTypes can also be removed, and the initialization
code for it?

[Karl, 2014-12-15 21:45:07]

Committed patchset #4 (id:60001) manually as
4019f0843ff2efdde366402f692f0853a206bac8 (presubmit successful).

[Karl, 2014-12-15 21:45:19]

https://codereview.chromium.org/805943002/diff/20001/src/IceTypeConverter.h
File src/IceTypeConverter.h (left):

https://codereview.chromium.org/805943002/diff/20001/src/IceTypeConverter.h#o...
src/IceTypeConverter.h:41: return LLVMTypes.at(Ty);
On 2014/12/15 21:05:32, jvoung wrote:
> I think this means that LLVMTypes can also be removed, and the initialization
> code for it?

Done.