Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 805913004: Increase the sharding parallelism for browser_tests on Mac and Windows. (Closed)

Created:
6 years ago by jam
Modified:
6 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the sharding parallelism for browser_tests on Mac and Windows. With the NG trybots using the buildbot value, browser_tests' sharding value regressed from the original 8 to 5 shards. The bots are now seeing more delays. Bump everything up to 10. R=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a5ac9e8a06e65e1292f1ab5436275220ea367991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M testing/buildbot/chromium.mac.json View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
6 years ago (2014-12-15 20:33:44 UTC) #2
M-A Ruel
I fear 10 may be a bit on the high side which would lower the ...
6 years ago (2014-12-15 20:36:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805913004/1
6 years ago (2014-12-15 20:42:05 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5ac9e8a06e65e1292f1ab5436275220ea367991 Cr-Commit-Position: refs/heads/master@{#308408}
6 years ago (2014-12-15 20:44:01 UTC) #7
jam
Committed patchset #1 (id:1) manually as a5ac9e8a06e65e1292f1ab5436275220ea367991.
6 years ago (2014-12-15 20:44:13 UTC) #8
jam
6 years ago (2014-12-15 20:46:06 UTC) #9
Message was sent while issue was closed.
On 2014/12/15 20:36:26, M-A Ruel wrote:
> I fear 10 may be a bit on the high side which would lower the efficiency, e.g.
> the time spent downloading the files vs the time spent running the test shard.
> In practice, this lower efficiency could reduce overall throughput. Sadly we
are
> not measuring this (yet).

yeah I agree, I worried about this too but didn't find data on the swarming
pages showing how much is spent downloading the files.. so i thought we'd try
this out and see.

> 
> lgtm anyway.

Powered by Google App Engine
This is Rietveld 408576698