Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8059006: Additional update on Pepper IME API and boilerplate thunk/proxy implementation. (Closed)

Created:
9 years, 2 months ago by kinaba
Modified:
9 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Additional update on Pepper IME API and boilerplate thunk/proxy implementation. BUG=59425 TEST=Check that ppapi_tests compile (with GYP_DEFINES=shared_library, too). This CL is the second (out of three) part for adding IME support for PPAPI. It reflects comments from James Su to the previous CL: http://codereview.chromium.org/7882004. - Renamed ..._COMPOSTION_START to _IME_COMPOSITON_START. - Changed to assure GetSegment to return a strictly increasing sequence of segmentation points from 0 to the length. and, - Added the mostly boilerplate code for interfacing with in-process & out-of-process plugins. The actual implementation of the IME support will come as the next and the last part of this series of patches. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103234

Patch Set 1 #

Patch Set 2 : Make win_shared happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -86 lines) Patch
M ppapi/api/dev/ppb_ime_input_event_dev.idl View 1 chunk +12 lines, -17 lines 0 comments Download
M ppapi/api/dev/ppb_text_input_dev.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/api/ppb_input_event.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/c/dev/ppb_ime_input_event_dev.h View 2 chunks +12 lines, -18 lines 0 comments Download
M ppapi/c/dev/ppb_text_input_dev.h View 2 chunks +1 line, -5 lines 0 comments Download
M ppapi/c/ppb_input_event.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/cpp/dev/ime_input_event_dev.h View 1 chunk +14 lines, -8 lines 0 comments Download
M ppapi/cpp/dev/ime_input_event_dev.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M ppapi/cpp/dev/text_input_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/dev/text_input_dev.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 4 chunks +17 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_text_input_proxy.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_text_input_proxy.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M ppapi/shared_impl/function_group_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/input_event_impl.h View 4 chunks +10 lines, -1 line 0 comments Download
M ppapi/shared_impl/input_event_impl.cc View 2 chunks +27 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_input_event_api.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_input_event_thunk.cc View 2 chunks +62 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_text_input_api.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_text_input_thunk.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_text_input_impl.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_text_input_impl.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kinaba
Brett, sorry to steal your time, but could you give me LG for this? Previous ...
9 years, 2 months ago (2011-09-27 09:38:57 UTC) #1
brettw
9 years, 2 months ago (2011-09-28 19:56:05 UTC) #2
LGTM rubberstamp

Powered by Google App Engine
This is Rietveld 408576698