Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 8059: Port parts of chrome/common to Linux.... (Closed)

Created:
12 years, 2 months ago by please use my chromium address
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Port parts of chrome/common to Linux. This probably needs some bigger adjustments. Some things need to be decided, like where to store profile files on Linux/Mac. BUG=3649

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -33 lines) Patch
M chrome/common/chrome_paths.cc View 1 2 3 4 5 6 6 chunks +51 lines, -23 lines 0 comments Download
M chrome/common/common.scons View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 2 3 4 5 6 8 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
please use my chromium address
12 years, 2 months ago (2008-10-22 17:12:06 UTC) #1
please use my chromium address
*ping*
12 years, 2 months ago (2008-10-23 17:39:15 UTC) #2
dank
OK except for needing to use xdg-user-dirs to get directory name for Desktop http://codereview.chromium.org/8059/diff/1/3 File ...
12 years, 2 months ago (2008-10-23 17:55:00 UTC) #3
Evan Martin
I think it'd be ok to punt on special directory locations (e.g. NOTIMPLEMENTED()) until we ...
12 years, 2 months ago (2008-10-23 19:43:14 UTC) #4
please use my chromium address
On 2008/10/23 19:43:14, Evan Martin wrote: > I think it'd be ok to punt on ...
12 years, 2 months ago (2008-10-23 20:07:59 UTC) #5
Mark Mentovai
LG with this change http://codereview.chromium.org/8059/diff/206/9 File chrome/common/chrome_paths.cc (right): http://codereview.chromium.org/8059/diff/206/9#newcode70 Line 70: #if defined(OS_WIN) This is ...
12 years, 2 months ago (2008-10-23 20:53:44 UTC) #6
please use my chromium address
On 2008/10/23 20:53:44, Mark Mentovai wrote: > LG with this change > > http://codereview.chromium.org/8059/diff/206/9 > ...
12 years, 2 months ago (2008-10-24 16:54:58 UTC) #7
Mark Mentovai
Oh, I didn't catch that the same thing applied to path_buf being moved. Yes, I ...
12 years, 2 months ago (2008-10-24 17:07:35 UTC) #8
please use my chromium address
On 2008/10/24 17:07:35, Mark Mentovai wrote: > Oh, I didn't catch that the same thing ...
12 years, 2 months ago (2008-10-24 17:14:29 UTC) #9
Mark Mentovai
Checked in r3932 with the changes noted. http://codereview.chromium.org/8059/diff/211/30 File chrome/common/chrome_paths.cc (right): http://codereview.chromium.org/8059/diff/211/30#newcode87 Line 87: cur->assign(path_buf); ...
12 years, 2 months ago (2008-10-24 18:32:38 UTC) #10
jar (doing other things)
http://codereview.chromium.org/8059/diff/211/31 File chrome/common/logging_chrome.cc (right): http://codereview.chromium.org/8059/diff/211/31#newcode97 Line 97: const wchar_t* log_file_name = GetLogFileName().c_str() I don't think ...
12 years, 2 months ago (2008-10-24 22:28:07 UTC) #11
please use my chromium address
On 2008/10/24 22:28:07, jar wrote: > http://codereview.chromium.org/8059/diff/211/31 > File chrome/common/logging_chrome.cc (right): > > http://codereview.chromium.org/8059/diff/211/31#newcode97 > ...
12 years, 2 months ago (2008-10-25 07:52:21 UTC) #12
please use my chromium address
On 2008/10/25 07:52:21, phajdan.jr wrote: > On 2008/10/24 22:28:07, jar wrote: > > http://codereview.chromium.org/8059/diff/211/31 > ...
12 years, 1 month ago (2008-10-30 14:54:50 UTC) #13
please use my chromium address
Patch updated.
12 years, 1 month ago (2008-11-05 16:51:28 UTC) #14
Evan Martin
12 years, 1 month ago (2008-11-07 20:06:27 UTC) #15
r5012

Powered by Google App Engine
This is Rietveld 408576698