Issue 805893003: mojo: Don't put override on methods overriding blink interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805893003: mojo: Don't put override on methods overriding blink interfaces. (Closed)

Created:
6 years ago by danakj

Modified:
6 years ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Don't put override on methods overriding blink interfaces. Then we require 3 sided patches instead of 2 sided. R=jamesr Committed: https://crrev.com/122f1d2b8e2a671f069e986fa6cc5486ccfa4716 Cr-Commit-Position: refs/heads/master@{#308407}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -21 lines)			Patch
	M	mojo/services/html_viewer/weblayertreeview_impl.h	View		1 chunk	+19 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805893003/1

6 years ago (2014-12-15 18:21:25 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-15 20:40:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/122f1d2b8e2a671f069e986fa6cc5486ccfa4716
Cr-Commit-Position: refs/heads/master@{#308407}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages