Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 805883003: GN build: add content/public/common:mojo_bindings dependency to content/app:both (Closed)

Created:
6 years ago by timvolodine
Modified:
6 years ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN build: add content/public/common:mojo_bindings dependency to content/app:both Without this dependency the compiler cannot find permission_status.mojom.h when compiling content/app:both target from scratch. BUG= Committed: https://crrev.com/ebfb0de18948b49bbee7f07c406d3bbad82a3b5b Cr-Commit-Position: refs/heads/master@{#309211}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
timvolodine
6 years ago (2014-12-17 19:31:19 UTC) #2
timvolodine
+ avi@ : jam@ is OOO could you have a look pls?
6 years ago (2014-12-19 16:07:20 UTC) #4
Avi (use Gerrit)
lgtm
6 years ago (2014-12-19 16:10:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805883003/20001
6 years ago (2014-12-19 16:18:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-19 16:36:07 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-19 16:37:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebfb0de18948b49bbee7f07c406d3bbad82a3b5b
Cr-Commit-Position: refs/heads/master@{#309211}

Powered by Google App Engine
This is Rietveld 408576698