Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 805863002: Push API: rename to endpoint and registrationId [1/3] (Closed)

Created:
6 years ago by Michael van Ouwerkerk
Modified:
6 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: rename to endpoint and registrationId. [1/3] This is part of a series: [1] This CL [2] https://codereview.chromium.org/795153003/ [3] https://codereview.chromium.org/802393002/ BUG=442343 Committed: https://crrev.com/c4983d0d04b0b3349756cc0bad45dd13324cf82b Cr-Commit-Position: refs/heads/master@{#308399}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/test/data/push_messaging/push_test.js View 1 chunk +16 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
6 years ago (2014-12-15 16:57:26 UTC) #2
Peter Beverloo
lgtm
6 years ago (2014-12-15 17:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805863002/20001
6 years ago (2014-12-15 18:47:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 19:56:15 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 19:58:07 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4983d0d04b0b3349756cc0bad45dd13324cf82b
Cr-Commit-Position: refs/heads/master@{#308399}

Powered by Google App Engine
This is Rietveld 408576698