Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: ui/base/ime/input_method_imm32.cc

Issue 80583002: [FYI] All-in-one OnCandidateWindow{Show,Update,Hide} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_imm32.cc
diff --git a/ui/base/ime/input_method_imm32.cc b/ui/base/ime/input_method_imm32.cc
index 074f37cd9ac6ae738861ca79f52f53987ec73f6d..7cb28f491264560b9490155c856298e0473551e2 100644
--- a/ui/base/ime/input_method_imm32.cc
+++ b/ui/base/ime/input_method_imm32.cc
@@ -238,9 +238,17 @@ LRESULT InputMethodIMM32::OnImeNotify(UINT message,
switch (wparam) {
case IMN_OPENCANDIDATE:
is_candidate_popup_open_ = true;
+ NotifyCandidateWindowStateChanged();
yukawa 2013/11/25 05:07:42 I'm not sure if we can safely call back external c
break;
case IMN_CLOSECANDIDATE:
is_candidate_popup_open_ = false;
+ NotifyCandidateWindowStateChanged();
+ break;
+ case IMN_CHANGECANDIDATE:
+ // TODO(kochi): The IME API expects this event to notify window size change,
+ // while this may fire more often without window resize. There is no generic
yukawa 2013/11/25 05:07:42 "There is no generic way to get bounds of candidat
+ // way to get bounds of candidate window.
+ NotifyCandidateWindowStateChanged();
break;
}

Powered by Google App Engine
This is Rietveld 408576698