Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 805813004: [GN] Output external snapshot blobs in out directory. (Closed)

Created:
6 years ago by rmcilroy
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[GN] Output external snapshot blobs in out directory. The snapshot and natives blob files should be output in the out directory instead of the gen directory so that they can be picked up by the executable. BUG=421063 LOG=N Committed: https://crrev.com/94071011acf544eef5bc1476e138dc32ba3f959b Cr-Commit-Position: refs/heads/master@{#25827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmcilroy
Jochen, PTAL, thanks.
6 years ago (2014-12-15 16:12:07 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-15 16:15:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805813004/1
6 years ago (2014-12-15 16:34:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 17:01:04 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94071011acf544eef5bc1476e138dc32ba3f959b
Cr-Commit-Position: refs/heads/master@{#25827}

Powered by Google App Engine
This is Rietveld 408576698