Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: content/renderer/media/peer_connection_tracker.cc

Issue 805813003: Update InternalStatsObserver to use the updated OnComplete callback in StatsObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/peer_connection_tracker.cc
diff --git a/content/renderer/media/peer_connection_tracker.cc b/content/renderer/media/peer_connection_tracker.cc
index 25f1b2df9aadb8585bc2482a29dbd37992065448..6c2b6f4468769622e01cbccd2988f999c193b51c 100644
--- a/content/renderer/media/peer_connection_tracker.cc
+++ b/content/renderer/media/peer_connection_tracker.cc
@@ -215,10 +215,11 @@ static base::DictionaryValue* GetDictValueStats(
base::ListValue* values = new base::ListValue();
dict->Set("values", values);
- for (size_t i = 0; i < report.values.size(); ++i) {
- values->AppendString(report.values[i].display_name());
- values->AppendString(report.values[i].value);
+ for (const auto& v : report.values) {
+ values->AppendString(v.display_name());
+ values->AppendString(v.value);
}
+
return dict;
}
@@ -247,11 +248,11 @@ class InternalStatsObserver : public webrtc::StatsObserver {
InternalStatsObserver(int lid)
: lid_(lid), main_thread_(base::ThreadTaskRunnerHandle::Get()) {}
- void OnComplete(const std::vector<webrtc::StatsReport>& reports) override {
+ void OnComplete(const webrtc::StatsReports& reports) override {
scoped_ptr<base::ListValue> list(new base::ListValue());
- for (size_t i = 0; i < reports.size(); ++i) {
- base::DictionaryValue* report = GetDictValue(reports[i]);
+ for (const auto* r : reports) {
+ base::DictionaryValue* report = GetDictValue(*r);
if (report)
list->Append(report);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698