Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 805773004: Create DOMWindowStorage as a DOMWindowLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalDOMWindow.cpp
diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp
index 82b4a6071ed4cbfd093481cb668b58438aa6a892..0a2a8d78808e113c82e59aedd1297eaed38b5798 100644
--- a/Source/core/frame/LocalDOMWindow.cpp
+++ b/Source/core/frame/LocalDOMWindow.cpp
@@ -1569,16 +1569,6 @@ DOMWindowCSS* LocalDOMWindow::css() const
return m_css.get();
}
-static void didAddStorageEventListener(LocalDOMWindow* window)
-{
- // Creating these blink::Storage objects informs the system that we'd like to receive
- // notifications about storage events that might be triggered in other processes. Rather
- // than subscribe to these notifications explicitly, we subscribe to them implicitly to
- // simplify the work done by the system.
- window->localStorage(IGNORE_EXCEPTION);
- window->sessionStorage(IGNORE_EXCEPTION);
-}
-
bool LocalDOMWindow::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
if (!EventTarget::addEventListener(eventType, listener, useCapture))
@@ -1589,8 +1579,6 @@ bool LocalDOMWindow::addEventListener(const AtomicString& eventType, PassRefPtr<
if (Document* document = this->document()) {
document->addListenerTypeIfNeeded(eventType);
- if (eventType == EventTypeNames::storage)
- didAddStorageEventListener(this);
}
lifecycleNotifier().notifyAddEventListener(this, eventType);

Powered by Google App Engine
This is Rietveld 408576698